Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed the example.
In TaggedS3Bucket example this documents re-assigne value into this.tagsInput with spread operator like this.
I changed to
What’s the difference?
When use …
AKA spread operator
is a kind of duplicate mechanismAnd usually use for
dont want impact to original value.
When using Object.assign it’s just extend the original object
In this document example …this.tagsInput is used for assing itself.
which means
generate new object and assign to original object
It’s working but not best practice.
If you change to Object.assign approach (my offer)
I love Terraform, and I wish Terraform document offer best practice
Thank you.