Added the ability to configure template delimiters on Pod annotations #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flaviolemos78
force-pushed
the
feat/hcl-configurable-template-delimiters
branch
3 times, most recently
from
44db950
to
4b3a42a
Compare
flaviolemos78
force-pushed
the
feat/hcl-configurable-template-delimiters
branch
from
4b3a42a
to
da9288a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some custom resources where Pod templates are used, and their respective controllers may run some template engine on top of it using the same configured templates delimiters (e.g: argo rollouts analysis template), causing errors due to conflicting delimiters. This PR adds the ability to configure consul template delimiters though Pod annotations.