fix: prevent using IRSA token for Kubernetes auth #545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
uchanchlani
pushed a commit
to uchanchlani/vault-k8s
that referenced
this pull request
Jan 17, 2024
… variables and flags Also fixes using AWS IRSA token by mistake if both included in the pod's volume hashicorp#544 This maybe a better fix then the proposed hashicorp#545 pull request as this is likely more future-proof to other third party k8s provider launching their own Service Account Token injection, assuming the third party k8s provider will follow the unsaid convention of injecting the token in the <third.party.url>/serviceaccount/token path
uchanchlani
pushed a commit
to uchanchlani/vault-k8s
that referenced
this pull request
Jan 17, 2024
…orp#577 Also fixes using AWS IRSA token by mistake if both included in the pod's volume hashicorp#544 This maybe a better fix then the proposed hashicorp#545 pull request as this is likely more future-proof to other third party k8s provider launching their own Service Account Token injection, assuming the third party k8s provider will follow the unsaid convention of injecting the token in the <third.party.url>/serviceaccount/token path
uchanchlani
added a commit
to uchanchlani/vault-k8s
that referenced
this pull request
Jan 17, 2024
…orp#577 Also fixes using AWS IRSA token by mistake if both included in the pod's volume hashicorp#544 This maybe a better fix then the proposed hashicorp#545 pull request as this is likely more future-proof to other third party k8s provider launching their own Service Account Token injection, assuming the third party k8s provider will follow the unsaid convention of injecting the token in the <third.party.url>/serviceaccount/token path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Skip IRSA token when detecting the service account token to use for the Kubernetes auth method.
I tried to follow the same logic used elsewhere for detecting the IRSA token.
Fixes
#544