Add a configurable delay before writing a dynamic secret #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes hashicorp#271 Some services (such as AWS IAM) are eventually consistent and require some time between generating the secret, and using the secret. Without this delay our services can't access AWS for a short while immediately after the secret rotation happens.
|
Hey @benashz This is a blocker for us from using VSO. |
…ecrets-operator into add_artifical_delay
|
Is it possible for this change to be merged? I'm happy to do the work to get it updated, but I'm not certain it will actually get prioritised and merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #271
Some services (such as AWS IAM) are eventually consistent and require some time between generating the secret, and using the secret.
Without this delay our services can't access AWS for a short while immediately after the secret rotation happens.
I'm not sure if my tests are sane. They could introduce some flakiness.