VSS/instant-updates: Improve filtering of kv-v2 events #926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The VSS controller drops some events of kv-v2 secrets because it expects a wrong path to be set. Most events use the pattern
<secret-mount>/data/<secret-path>, but some operations, like delete and undelete, will include the operation instead ofdatain its path. Therefore, it would be better if the controller also accepts<secret-mount>/<operation>/<secret-path>as a valid path.Additionally, it would be helpful if the controller uses the namespaces configured in the referenced VaultAuth resource as fallback while filtering the events. This would reduce the required configuration if authentication and secrets are in the same namespace.