Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Azure Secrets v0.17.3 in release/1.16.x #27655

Conversation

vinay-gopalan
Copy link
Contributor

Description

Upgrade Azure Secrets to v0.17.3 which resolves a panic bug.

TODO only if you're a HashiCorp employee

  • Labels: If this PR is the CE portion of an ENT change, and that ENT change is
    getting backported to N-2, use the new style backport/ent/x.x.x+ent labels
    instead of the old style backport/x.x.x labels.
  • Labels: If this PR is a CE only change, it can only be backported to N, so use
    the normal backport/x.x.x label (there should be only 1).
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Jul 1, 2024
@vinay-gopalan vinay-gopalan added this to the 1.16.6 milestone Jul 1, 2024
@vinay-gopalan vinay-gopalan requested a review from a team July 1, 2024 22:04
Copy link

github-actions bot commented Jul 1, 2024

CI Results: failed ❌

Copy link

github-actions bot commented Jul 1, 2024

Build Results:
Build failed for these jobs: artifacts:failure. Please refer to this workflow to learn more: https://github.com/hashicorp/vault/actions/runs/9751657594

@fairclothjm
Copy link
Contributor

fairclothjm commented Jul 2, 2024

@vinay-gopalan We will need to close this CE pull request and open a new PR against the Ent 1.16.x+ent branch. We now release CE only for N (1.17). N-1 and N-2 are released only in Enterprise form.

@vinay-gopalan
Copy link
Contributor Author

@vinay-gopalan We will need to close this CE pull request and open a new PR against the Ent 1.16.x+ent branch. We now release CE only for N (1.17). N-1 and N-2 are released only in Enterprise form.

Thanks @fairclothjm! Opened up a new PR up against Vault ENT 1.16.x branch.

@vinay-gopalan vinay-gopalan deleted the VAULT-26583/backport-azure-secrets-0.17.3-upgrade branch July 2, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants