-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VAULT-32188: Enos test for PKI certificates #29007
base: main
Are you sure you want to change the base?
Conversation
CI Results: |
Build Results: |
d275880
to
fd34473
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hot dang! Good job on your fist scenario expansion. Things are looking good!
It looks like we're missing updates to steps that are implemented by the vault_verify_secrets_engines_read
module in a few scenarios:
- Autopilot
- DR Replication
- PR Replication
- Seal HA
We'll need to get those updates with the vault_root_token
variable. It would be nice to create a test branch in vault-enterprise
with all the changes to verify these changes so that when the CE -> Ent merge happens that there won't be any surprises.
While I didn't restate the feedback, the feedback on the read/pki
module also applies to the create/pki
module.
enos/modules/verify_secrets_engines/scripts/kv-pki-verify-certificates.sh
Outdated
Show resolved
Hide resolved
enos/modules/verify_secrets_engines/scripts/kv-pki-verify-certificates.sh
Outdated
Show resolved
Hide resolved
enos/modules/verify_secrets_engines/scripts/kv-pki-verify-certificates.sh
Outdated
Show resolved
Hide resolved
enos/modules/verify_secrets_engines/scripts/kv-pki-verify-certificates.sh
Outdated
Show resolved
Hide resolved
02fa4e9
to
258b800
Compare
Description
VAULT-32188: Create Enos test for PKI issuing and signing certificates
TODO only if you're a HashiCorp employee
backport/
label that matches the desired release branch. Note that in the CE repo, the latest release branch will look likebackport/x.x.x
, but older release branches will bebackport/ent/x.x.x+ent
.of a public function, even if that change is in a CE file, double check that
applying the patch for this PR to the ENT repo and running tests doesn't
break any tests. Sometimes ENT only tests rely on public functions in CE
files.
in the PR description, commit message, or branch name.
description. Also, make sure the changelog is in this PR, not in your ENT PR.