Add GCP configuration details #29120

Monkeychip · 2024-12-06T16:52:21Z

Description

What does this PR do?

TODO only if you're a HashiCorp employee

Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
- LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
of a public function, even if that change is in a CE file, double check that
applying the patch for this PR to the ENT repo and running tests doesn't
break any tests. Sometimes ENT only tests rely on public functions in CE
files.
Jira: If this change has an associated Jira, it's referenced either
in the PR description, commit message, or branch name.
RFC: If this change has an associated RFC, please link it in the description.
ENT PR: If this change has an associated ENT PR, please link it in the
description. Also, make sure the changelog is in this PR, not in your ENT PR.

github-actions · 2024-12-06T17:14:41Z

CI Results: failed ❌

* VAULT-32159 CE changes for PKI metrics * Whoops, printf

* VAULT-32159 docs for pki metrics * Issuers, not certs

* VAULT-32159 issuers not certs CE changes * Typo

Co-authored-by: Sarah Chavis <[email protected]> --------- Co-authored-by: Robert <[email protected]> Co-authored-by: Sarah Chavis <[email protected]>

* Use DRBG based RSA key generation everywhere * switch to the conditional generator * Use DRBG based RSA key generation everywhere * switch to the conditional generator * Add an ENV var to disable the DRBG in a pinch * update go.mod * Use DRBG based RSA key generation everywhere * switch to the conditional generator * Add an ENV var to disable the DRBG in a pinch * Use DRBG based RSA key generation everywhere * update go.mod * fix import * Remove rsa2 alias, remove test code * move cryptoutil/rsa.go to sdk * move imports too * remove makefile change * rsa2->rsa * more rsa2->rsa, remove test code * fix some overzelous search/replace * Update to a real tag * changelog * copyright * work around copyright check * work around copyright check pt2 * bunch of dupe imports * missing import * wrong license * fix go.mod conflict * missed a spot * dupe import

) * Update the doc title and description for SEO improvements * Update the side-nav name

- Add production hardening document to concepts from tutorial - Update content for linting and grammar

* Do not use static certificates for diagnose tests * Fix operator command tests, move PKI CA creation code into testhelper lib * Fix compilation error from refactoring

…29117)

* Fix return certificate expiry time from NearExpiration - The duration returned from the NearExpiration is supposed to represent the time till expiry from now and not the calculated time a month from now. * Add cl * PR feedback

Co-authored-by: hc-github-team-secure-vault-ecosystem <[email protected]>

* decode url in the serializer for oracle connection_url * add serializer test * add test for oracle * add test back, remove decode-url helper * update comment and test * link jiras VAULT-32830 VAULT-29785 * add changelog * add test

* OSS Patch OSS Patch Fixing a build issue * Revert "OSS Patch" This reverts commit 2cce608. * OSS-Patch * Fix test issue

--------- Co-authored-by: Thy Ton <[email protected]>

* configuration details only changes * azure configuration acceptance test * clean up * change attrs to display attrs and reuse formFields * missed some * clean up * Update ui/app/helpers/mountable-secret-engines.js Co-authored-by: claire bontempo <[email protected]> * remove extra conditional * fix test for oss runs * clean up the logic for checking if the model has been configured * remove formatTtl * fix broken conditional * address pr comments * clean up clean up everybody lets clean up --------- Co-authored-by: claire bontempo <[email protected]>

…29090) * implementation and test * changelog * verify servers are healthy before removing

…29147)

* OSS Changes Patch * Added changelog

* use const for in relation to vault eventing metadata * update comments * fix comment lengths

* Match the page_title and H1 header * Update website/content/docs/secrets/databases/index.mdx Co-authored-by: Brian Shumate <[email protected]> --------- Co-authored-by: Brian Shumate <[email protected]>

Co-authored-by: Ken Keller <[email protected]>

…Enterprise (#29144) * add docs changes for enabled field * remove extra space * updating docs

* Match the page_title with H1 header * Fix typos: rote --> rotate

* Fix style inconsistency * Fix typos * Update website/content/docs/platform/k8s/vso/secret-transformation.mdx Co-authored-by: Jonathan Frappier <[email protected]> * Update website/content/docs/platform/k8s/helm/terraform.mdx Co-authored-by: Theron Voran <[email protected]> * Update website/content/docs/platform/k8s/injector/annotations.mdx Co-authored-by: Theron Voran <[email protected]> --------- Co-authored-by: Jonathan Frappier <[email protected]> Co-authored-by: Theron Voran <[email protected]>

* =passback mfa_requirement for oidc login methods * =pass SAML mfa requirement * add comments * add acceptance tests * add helper * update callback args for auth jwt * add changelog * update changelog * is this line necessary? * fetch token data for display name, this commit can be undone when BE fixes VAULT-32462 * change error handling, add comments * update capitalization * revert capitalization * reword changelog * clarify comments * Update changelog/28873.txt

* db: fix skip-import-rotation/rootless integration * prevent setting both password and self_managed_password * move func call and add comment

-path must bevor auth method, otherwise an error is thrown "Command flags must be provided before positional arguments. The following arguments will not be parsed as flags: [-path=my-auth]" Co-authored-by: Yoko Hyakuna <[email protected]>

* add testing before model changes * add enterprise self_managed attr, update tests * add postgres params * add changelog * update test * cleanup filter function * fix nits

* Add ops quick start, update nav * Update website/content/docs/get-started/operations-qs.mdx Co-authored-by: Yoko Hyakuna <[email protected]> * Update website/content/docs/get-started/operations-qs.mdx Co-authored-by: Yoko Hyakuna <[email protected]> * Update website/content/docs/get-started/operations-qs.mdx Co-authored-by: Sarah Chavis <[email protected]> * Update website/content/docs/get-started/operations-qs.mdx Co-authored-by: Sarah Chavis <[email protected]> * Update website/content/docs/get-started/operations-qs.mdx Co-authored-by: Sarah Chavis <[email protected]> * Update website/content/docs/get-started/operations-qs.mdx Co-authored-by: Sarah Chavis <[email protected]> * Update website/content/docs/get-started/operations-qs.mdx Co-authored-by: Sarah Chavis <[email protected]> * Update website/content/docs/get-started/operations-qs.mdx Co-authored-by: Sarah Chavis <[email protected]> * Update website/content/docs/get-started/operations-qs.mdx Co-authored-by: Sarah Chavis <[email protected]> * Update website/content/docs/get-started/operations-qs.mdx Co-authored-by: Sarah Chavis <[email protected]> * Update website/content/docs/get-started/operations-qs.mdx Co-authored-by: Sarah Chavis <[email protected]> * Update website/content/docs/get-started/operations-qs.mdx Co-authored-by: Sarah Chavis <[email protected]> * Update website/content/docs/get-started/operations-qs.mdx Co-authored-by: Sarah Chavis <[email protected]> * Update website/content/docs/get-started/operations-qs.mdx Co-authored-by: Sarah Chavis <[email protected]> * Update website/content/docs/get-started/operations-qs.mdx Co-authored-by: Sarah Chavis <[email protected]> * Update website/content/docs/get-started/operations-qs.mdx Co-authored-by: Sarah Chavis <[email protected]> * Update website/content/docs/get-started/operations-qs.mdx Co-authored-by: Sarah Chavis <[email protected]> * Update website/content/docs/get-started/operations-qs.mdx Co-authored-by: Sarah Chavis <[email protected]> * Update website/content/docs/get-started/operations-qs.mdx Co-authored-by: Sarah Chavis <[email protected]> * Update website/content/docs/get-started/operations-qs.mdx Co-authored-by: Sarah Chavis <[email protected]> * Update website/content/docs/get-started/operations-qs.mdx Co-authored-by: Sarah Chavis <[email protected]> * Update website/content/docs/get-started/operations-qs.mdx Co-authored-by: Sarah Chavis <[email protected]> * Update website/content/docs/get-started/operations-qs.mdx Co-authored-by: Sarah Chavis <[email protected]> * Update website/content/docs/get-started/operations-qs.mdx Co-authored-by: Sarah Chavis <[email protected]> * Update website/content/docs/get-started/operations-qs.mdx Co-authored-by: Sarah Chavis <[email protected]> * Update website/content/docs/get-started/operations-qs.mdx Co-authored-by: Sarah Chavis <[email protected]> * Update website/content/docs/get-started/operations-qs.mdx Co-authored-by: Sarah Chavis <[email protected]> * Update website/content/docs/get-started/operations-qs.mdx Co-authored-by: Sarah Chavis <[email protected]> * Update website/content/docs/get-started/operations-qs.mdx Co-authored-by: Sarah Chavis <[email protected]> * Update website/content/docs/get-started/operations-qs.mdx Co-authored-by: Sarah Chavis <[email protected]> * Update website/content/docs/get-started/operations-qs.mdx Co-authored-by: Sarah Chavis <[email protected]> * Update website/content/docs/get-started/operations-qs.mdx Co-authored-by: Sarah Chavis <[email protected]> * Update website/content/docs/get-started/operations-qs.mdx Co-authored-by: Sarah Chavis <[email protected]> * Update website/content/docs/get-started/operations-qs.mdx Co-authored-by: Sarah Chavis <[email protected]> * Update website/content/docs/get-started/operations-qs.mdx Co-authored-by: Sarah Chavis <[email protected]> * Update website/content/docs/get-started/operations-qs.mdx Co-authored-by: Sarah Chavis <[email protected]> * Updates --------- Co-authored-by: Yoko Hyakuna <[email protected]> Co-authored-by: Sarah Chavis <[email protected]>

helper/testhelpers/pki/pkihelper.go

+	"crypto/x509/pkix"
+	"encoding/pem"
+	"math/big"
+	mathrand2 "math/rand/v2"


vault/raft.go

+		// If the node has been removed, we should continue to startup but in
+		// the removed state
+		if errors.Is(err, errRemovedHANode) {
+			c.logger.Error("failed to join raft cluster", "error", err)


…ise users (#29047) * transfer over all changes from original pr * changelog * add serialize catch for no empty string environment * move ttl format logic to parent route * Update 29047.txt * clean up some comments * Update changelog/29047.txt Co-authored-by: claire bontempo <[email protected]> * Update changelog/29047.txt Co-authored-by: claire bontempo <[email protected]> * Update ui/app/components/secret-engine/configure-azure.hbs Co-authored-by: claire bontempo <[email protected]> * first round of addressing pr comments, holding off on the issue save flow for error messaging to keep separate * Update CODEOWNERS merge issue * small clean up tasks * updates * test coverage * small cleanup * small clean up * clean up * clean up getters on model --------- Co-authored-by: claire bontempo <[email protected]>

* Update the page description for SEO improvement * Update the description for SEO improvement * Update the description * Update website/content/docs/secrets/transform/ff3-tweak-details.mdx Co-authored-by: Jonathan Frappier <[email protected]> * Fixing a typo * Incorporate review feedback --------- Co-authored-by: Jonathan Frappier <[email protected]>

* Update the title & description for SEO improvement * Minor updates for style consistency * Revert back the change * Update website/content/docs/secrets/aws.mdx Co-authored-by: Sarah Chavis <[email protected]> --------- Co-authored-by: Sarah Chavis <[email protected]>

* Update the PKI secrets engine docs title & description * Update website/content/docs/secrets/pki/index.mdx Co-authored-by: Jonathan Frappier <[email protected]> * Incorporate the review feedback --------- Co-authored-by: Jonathan Frappier <[email protected]>

Various different CI jobs need Go modules in order to build or test Vault. To speed this up in CI we cache them in Github Actions. The caching requires downloading all modules first in order to upload them to the actions cache, which is performed by calling the `go-mod-download` Make target. This target will iterate over the directory tree and download Go modules in all directories that include a `go.mod` file. There are two small problems with this approach that we resolved with this PR: * Our `go-mod-download` target would download modules for all `go.mod`'s present in the directory tree, regardless of whether or not they are required to build or test Vault. Only downloading those required results in slightly smaller caches. * `tools/pipeline` is intentionally a separate Go module so as to not require its modules in order to build Vault, however, our `go-mod-download` downloading all modules requires the workflow environment to include auth credentials for internal modules. If a community contributed PRs modifies a `go.mod`, which in turn requires a new cache, the PR will always fail because it cannot download modules that require secrets. Now we avoid installing our `tools/pipeline` modules when generating our module cache which should allow community contributed PRs to execute build and Go tests, while skipping enos workflows which already required secrets and were thus skipped. Signed-off-by: Ryan Cragun <[email protected]>

* seo updates for config docs * fix content errors * Make KMS title consistent with other stanza titles

starting

4e6b792

github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Dec 6, 2024

VioletHynes and others added 27 commits December 18, 2024 15:15

VAULT-32159 CE changes for PKI metrics (#29103)

1ce5cb0

* VAULT-32159 CE changes for PKI metrics * Whoops, printf

VAULT-32159 docs for pki metrics (#29102)

ae9e9b9

* VAULT-32159 docs for pki metrics * Issuers, not certs

VAULT-32159 issuers not certs CE changes (#29105)

fc8297c

* VAULT-32159 issuers not certs CE changes * Typo

VAULT-32598: add docs for azure autosnapshot auth modes (#29073)

2d27db3

VAULT-32804: Add STS Fallback parameters to secrets-aws engine (#29051)

344a27c

Co-authored-by: Sarah Chavis <[email protected]> --------- Co-authored-by: Robert <[email protected]> Co-authored-by: Sarah Chavis <[email protected]>

Fix missing locking in mount tests (#29110)

17af255

[DOCS] Update the doc title and description for SEO improvements (#29100

64626e6

) * Update the doc title and description for SEO improvements * Update the side-nav name

Docs: add production hardening document (#29019)

e1068a4

- Add production hardening document to concepts from tutorial - Update content for linting and grammar

Do not use static certificates for diagnose tests (#29122)

d314abd

* Do not use static certificates for diagnose tests * Fix operator command tests, move PKI CA creation code into testhelper lib * Fix compilation error from refactoring

Fix decryption of raft bootstrap challenge in multi-seal scenarios. (#…

c51e1ac

…29117)

add ce changes for ecdsa hybrid (#29123)

37d2c9c

Update vault-plugin-secrets-openldap to v0.14.4 (#29131)

9f47115

Co-authored-by: hc-github-team-secure-vault-ecosystem <[email protected]>

UI: Decode Oracle database connection_url (#29114)

332dddc

* decode url in the serializer for oracle connection_url * add serializer test * add test for oracle * add test back, remove decode-url helper * update comment and test * link jiras VAULT-32830 VAULT-29785 * add changelog * add test

Reword raft challenge changelog (#29140)

2c8c9da

Send Global Data From Secondary to Primary During Upgrade (#29137)

b169f0d

* OSS Patch OSS Patch Fixing a build issue * Revert "OSS Patch" This reverts commit 2cce608. * OSS-Patch * Fix test issue

add vault build date to system view plugin env VAULT-32676 (#29082)

9e449d9

--------- Co-authored-by: Thy Ton <[email protected]>

VAULT-31758: Store when a node is removed in the raft stable store (#…

4df8a49

…29090) * implementation and test * changelog * verify servers are healthy before removing

Update changelog entry linking PKI considerations page for more info (#…

9285984

…29147)

Added LocalMount field to Export API (#29145)

bf6c68c

* OSS Changes Patch * Added changelog

Run benchmark only on main (and rename the f ile (#29142)

6a38c99

Update VSO docs for v0.9.1 (#29151)

995cfb0

OSS Changes Patch (#29154)

dd677b2

clarify fix to apply to all databases (#29156)

12fe2a0

use const for in relation to vault eventing metadata (#29130)

3d9ae36

* use const for in relation to vault eventing metadata * update comments * fix comment lengths

yhyakuna and others added 16 commits December 18, 2024 15:15

[DOCS] Match the page_title and H1 header (#29192)

d915643

* Match the page_title and H1 header * Update website/content/docs/secrets/databases/index.mdx Co-authored-by: Brian Shumate <[email protected]> --------- Co-authored-by: Brian Shumate <[email protected]>

make fmt (#29196)

6347754

Update server command - log-file parameter - folder value (#29061)

ef45467

Co-authored-by: Ken Keller <[email protected]>

OSS-Changes Patch (#29193)

827a0b3

Update docs to reflect that activity log cannot be disabled on Vault …

0305f80

…Enterprise (#29144) * add docs changes for enabled field * remove extra space * updating docs

[DOCS] Match the page_title with H1 header (#29204)

618d3db

* Match the page_title with H1 header * Fix typos: rote --> rotate

Do not error during retry join if the node is removed (#29210)

fa33c89

db: fix skip-import-rotation/rootless integration (#29202)

6a951d0

* db: fix skip-import-rotation/rootless integration * prevent setting both password and self_managed_password * move func call and add comment

add ui team to oidc and jwt codeowners (#29212)

69efed5

Add EDU as approvers for more granular targets (#29124)

7be3b2a

change order in first example (#29194)

25b080a

-path must bevor auth method, otherwise an error is thrown "Command flags must be provided before positional arguments. The following arguments will not be parsed as flags: [-path=my-auth]" Co-authored-by: Yoko Hyakuna <[email protected]>

Update the page title/description (#29218)

e56fd87

UI: Update PostgreSQL database params (#29200)

4178ae0

* add testing before model changes * add enterprise self_managed attr, update tests * add postgres params * add changelog * update test * cleanup filter function * fix nits

vercel bot deployed to Preview December 18, 2024 22:23 View deployment

github-advanced-security bot found potential problems Dec 18, 2024

View reviewed changes

Monkeychip and others added 9 commits December 18, 2024 15:36

Merge branch 'main' into ui/VAULT-32144/gcp-start

a80cf3e

most of the structure is in, time for clean up and testing

5bb5eee

[DOCS] SEO updates for config docs (#29242)

92214b0

* seo updates for config docs * fix content errors * Make KMS title consistent with other stanza titles

Merge branch 'main' into ui/VAULT-32144/gcp-start

71483ca

Monkeychip closed this Dec 20, 2024

Monkeychip deleted the ui/VAULT-32144/gcp-start branch December 20, 2024 18:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add GCP configuration details #29120

Add GCP configuration details #29120

Monkeychip commented Dec 6, 2024

github-actions bot commented Dec 6, 2024 •

edited

Loading

Add GCP configuration details #29120

Add GCP configuration details #29120

Conversation

Monkeychip commented Dec 6, 2024

Description

TODO only if you're a HashiCorp employee

github-actions bot commented Dec 6, 2024 • edited Loading

github-actions bot commented Dec 6, 2024 •

edited

Loading