[VAULT-33207] Update Policy Modal to add isHrefExternal to External Links

[beagins]

Description

What does this PR do? This is a followup PR to add isHrefExternal attribute to external HDS links in the Policy Modal
Original PR: #29254

Screenshots

ACL Policies: HCL Link

Endpoint Governing Policies: Sentinel Link

TODO only if you're a HashiCorp employee

• Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
  • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
• ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
  of a public function, even if that change is in a CE file, double check that
  applying the patch for this PR to the ENT repo and running tests doesn't
  break any tests. Sometimes ENT only tests rely on public functions in CE
  files.
• Jira: If this change has an associated Jira, it's referenced either
  in the PR description, commit message, or branch name.
• RFC: If this change has an associated RFC, please link it in the description.
• ENT PR: If this change has an associated ENT PR, please link it in the
  description. Also, make sure the changelog is in this PR, not in your ENT PR.

[github-actions]

CI Results:
All Go tests succeeded! ✅

[beagins]

yarn test:ent

1..219
# tests 219
# pass  209
# skip  10
# todo  0
# fail  0

# ok

[github-actions]

Build Results:
All builds succeeded! ✅

[hellobontempo]

I believe this needs one too. Then we're all set! "External" refers to any link outside the app so unless we're routing to another page inside the app, we should include this arg.

[beagins]

Ah gotcha! I just applied it to the links that were previously using the <ExternalLink/> component, I'll update it. Thank you!!

[hellobontempo]

That makes sense! The multiple use of "external" is confusing here. For additional context, we used to use this DocLink component to render links to our documentation, which extended from ExternalLink and just provided the first part of the path.

As we started using the HDS link components, we made the doc-link helper to use instead, which can be used directly in templates to build a doc link.

[hellobontempo]

Thanks! ✨