FIX: fix issue where hashes that are in binary format do not get thei… (

#1108)

* fix: fix issue where hashes that are in binary format do not get their cracked plaintext returned through the api

src/inc/utils/HashlistUtils.class.php

@@ -1130,20 +1130,23 @@ public static function getCrackedHashes($hashlistId, $user) {
     if (!AccessUtils::userCanAccessHashlists($lists, $user)) {
       throw new HTException("No access to the hashlists!");
     }
-
     $hashlistIds = Util::arrayOfIds($lists);
     $qF1 = new ContainFilter(Hash::HASHLIST_ID, $hashlistIds);
     $qF2 = new QueryFilter(Hash::IS_CRACKED, 1, "=");
     $hashes = [];
-    $entries = Factory::getHashFactory()->filter([Factory::FILTER => [$qF1, $qF2]]);
+    $isBinary = $hashlist->getFormat() != 0;
+    $factory = $isBinary ? Factory::getHashBinaryFactory() : Factory::getHashFactory();
+    $entries = $factory->filter([Factory::FILTER => [$qF1, $qF2]]);
     foreach ($entries as $entry) {
       $arr = [
         "hash" => $entry->getHash(),
         "plain" => $entry->getPlaintext(),
         "crackpos" => $entry->getCrackPos()
       ];
-      if (strlen($entry->getSalt()) > 0) {
-        $arr["hash"] .= $hashlist->getSaltSeparator() . $entry->getSalt();
+      if ($hashlist->getIsSalted()) {
+        if (strlen($entry->getSalt()) > 0) {
+          $arr["hash"] .= $hashlist->getSaltSeparator() . $entry->getSalt();
+        }
       }
       $hashes[] = $arr;
     }