Apiv2 #1128
Merged
Apiv2 #1128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JSON:API responses can be potentially be quite large, especially since no minification to the JSON output is performed. Adding deflate compression with reduce transfer sizes.
Focus on working on Users, GlobalPermissionGroups and AccessGroups
…i-standard' into feature/1018-convert-homebrew-apiv2-interface-to-jsonapi-standard
This file was never commited and missed, due to the wildcard *.lock pattern set in .gitigore https://getcomposer.org/doc/01-basic-usage.md#commit-your-composer-lock-file-to-version-control
Rename to reflect new naming (include)
It is confusing to mix expand with include. Thus rename all variables in python test code from expand to include.
The hashtopolis.py cannot be debugged with default Interactive debugging of VScode debugging of pytests. Thus make a small workaround based of the idea: https://stackoverflow.com/questions/62419998/how-can-i-get-pytest-to-not-catch-exceptions/62563106#62563106
Should be 404, how-ever this trow was not captured, due to incorrect ordering.
- PATCH/DELETE requires mapping to new format. - Helpers need some thinking on request/response. - Relation updates needs to be implemented.
When creating an object the ER relations are sent via JSON:API how-ever without an formal definition, there is no way of knowing whether something is considered an relation.
Add PoC conversion using Django tooling for reference purposes. This could be used as base for creating objects within the python libary (also to do some client-side checking as well).
- Updated pagination parameters from 'page[after]' and 'page[size]' to 'page[offset] and 'page[limit'] - This change aligns with the JSON:API specification for pagination (https://jsonapi.org/format/#fetching-pagination)
-changed 'page[after]' and 'page[size] to 'page[offset]' and 'page[limit]' in the link objects
…of an POST request
…GET requests for pagination
… next and previous for pagination
…tch to many relationship link
…liant to JSON API 1.1
jessevz
requested review from
s3inlc,
zyronix,
gluafamichl,
gpascal123 and
cv5ch
…tting no resource record responses in the metadata
|
Like discussed, I will just merge this PR and we will start reviewing and testing the new API on our local machines. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
APIv2 changes to adhere to JSON API standard version 1.1.
resolves #1018 #993 #733 #923