Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug/999 download file via new api #1130

Merged
merged 6 commits into from
Nov 21, 2024
Merged

Bug/999 download file via new api #1130

merged 6 commits into from
Nov 21, 2024

Conversation

jessevz
Copy link
Contributor

@jessevz jessevz commented Nov 21, 2024

fixes #999

@jessevz jessevz requested a review from gluafamichl November 21, 2024 09:10
gluafamichl
gluafamichl approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@gluafamichl gluafamichl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay for me, we will check it locally with the review of the V2 API

@gluafamichl gluafamichl merged commit fd5ba50 into dev Nov 21, 2024
1 check passed
@gluafamichl gluafamichl deleted the bug/999-download-file-via-new-API branch November 21, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gluafamichl gluafamichl gluafamichl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
🍺 Sprint November '24
Status: 🎉 Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jessevz @gluafamichl