FIXED error for unsupported php 8.4 in xdebug #1134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gluafamichl
approved these changes
Nov 28, 2024
jessevz
deleted the
1133-bug-build-containers-failing-because-of-new-php-version
branch
jessevz
added a commit
that referenced
this pull request
Nov 28, 2024
* FIXED error for unsupported php 8.4 in xdebug (#1134) * FIXED error for unsuported php 8.4 version by upgrading xdebug to version 3.4.0beta1 * temporarily fix by disabling php 8.4 deprecation warnings in apiv2 * Fixed preprocessor skip command bug. (#1126) * Fixed preprocessor skip command bug. * Added changelog entry. * Updated changelog entry version. * Use utf8mb4 as default encoding (#1127) * Use utf8mb4. * Added comment, added changelog entry. --------- Co-authored-by: jessevz <[email protected]> --------- Co-authored-by: gochujang-c <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
temporarily fix by upgrading xdebug to version 3.4.0beta1. When stable release of xdebug supports php version 8.4 we should change this line again.
Second part of the fix is to disable deprecation warning as errors in the apiv2 backend. php 8.4 introduces some deprecations (https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated). By throwing this as hard errors, the ci/cd pipeline fails so I had to disable it.