Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove simd on aarch64, but compile. #206

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jsoo1
Copy link

@jsoo1 jsoo1 commented Dec 10, 2023

We compile programs that depend on hw-json for both x86_64 and aarch64. Of course the simd extensions won't be available on aarch64 but it would be nice if hw-json could compile for the platform, anyways.

I think this would also need to be done in the cursor libraries, too. Or maybe this should instead be done in hw-simd or hw-json-simd instead? What do you think?

@newhoggy
Copy link
Member

newhoggy commented Jan 15, 2024

Thanks for the PR. Are you satisfied with the undefined in the PR? If so, I'm happy to merge and release.

Also, it probably should use error "not implemented" rather than undefined.

@jsoo1
Copy link
Author

jsoo1 commented Jan 15, 2024

I would be happy to change to error with a better explanation. Though I don't love user error prefix that would come with it.

@newhoggy
Copy link
Member

undefined calls error internally anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants