Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integration with Vector Databases #1
base: main
Are you sure you want to change the base?
Integration with Vector Databases #1
Changes from all commits
38e7adb
68fb991
64cba0e
240dc24
f101cd6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review of
LLM
class constructor.The constructor initializes a
VectorDB
instance. It's good practice to allow dependency injection for better testing and flexibility.Committable suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review of
VectorDB
class constructor.The constructor initializes the
PersistentClient
and sets up a collection with an embedding function. The hard-coded path for the database ("./chroma_db"
) could be made configurable to enhance flexibility in different environments.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review of
store_response
method.The method adds a single document to the collection. Using the collection's count as an ID is risky as it can lead to race conditions in a concurrent environment. Consider using a more robust method for generating unique IDs.
Committable suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add error handling to the querying process.
The loop for querying similar responses is clear and straightforward. However, adding error handling would improve the robustness of the test.
Committable suggestion