fix: correct lengths on random.Generate

hatchet-dev · Jun 25, 2024 · 1ef1c46 · 1ef1c46
1 parent 771054a
commit 1ef1c46
Show file tree

Hide file tree

Showing 7 changed files with 10 additions and 10 deletions.
diff --git a/api/v1/server/authn/session_helpers.go b/api/v1/server/authn/session_helpers.go
@@ -112,7 +112,7 @@ func (s *SessionHelpers) SaveOAuthState(
 	c echo.Context,
 	integration string,
 ) (string, error) {
-	state, err := random.Generate(16)
+	state, err := random.Generate(32)
 
 	if err != nil {
 		return "", err

diff --git a/cmd/hatchet-admin/cli/quickstart.go b/cmd/hatchet-admin/cli/quickstart.go
@@ -214,13 +214,13 @@ func setupCerts(generated *generatedConfigFiles) error {
 func generateKeys(generated *generatedConfigFiles) error {
 	color.New(color.FgGreen).Printf("Generating encryption keys for Hatchet server\n")
 
-	cookieHashKey, err := random.Generate(8)
+	cookieHashKey, err := random.Generate(16)
 
 	if err != nil {
 		return fmt.Errorf("could not generate hash key for instance: %w", err)
 	}
 
-	cookieBlockKey, err := random.Generate(8)
+	cookieBlockKey, err := random.Generate(16)
 
 	if err != nil {
 		return fmt.Errorf("could not generate block key for instance: %w", err)

diff --git a/internal/msgqueue/rabbitmq/rabbitmq.go b/internal/msgqueue/rabbitmq/rabbitmq.go
@@ -234,7 +234,7 @@ func (t *MessageQueueImpl) initQueue(sub session, q msgqueue.Queue) (string, err
 	name := q.Name()
 
 	if q.FanoutExchangeKey() != "" {
-		suffix, err := random.Generate(4)
+		suffix, err := random.Generate(8)
 
 		if err != nil {
 			t.l.Error().Msgf("error generating random bytes: %v", err)

diff --git a/internal/msgqueue/rabbitmq/rabbitmq_test.go b/internal/msgqueue/rabbitmq/rabbitmq_test.go
@@ -34,7 +34,7 @@ func TestMessageQueueIntegration(t *testing.T) {
 
 	require.NotNil(t, tq, "task queue implementation should not be nil")
 
-	id, _ := random.Generate(4) // nolint: errcheck
+	id, _ := random.Generate(8) // nolint: errcheck
 
 	// Test adding a task to a static queue
 	staticQueue := msgqueue.EVENT_PROCESSING_QUEUE
@@ -116,7 +116,7 @@ func TestDeadLetteringSuccess(t *testing.T) {
 
 	require.NotNil(t, tq, "task queue implementation should not be nil")
 
-	id, _ := random.Generate(4) // nolint: errcheck
+	id, _ := random.Generate(8) // nolint: errcheck
 
 	// Test adding a task to a static queue
 	staticQueue := msgqueue.EVENT_PROCESSING_QUEUE
@@ -174,7 +174,7 @@ func TestDeadLetteringExceedRetriesFailure(t *testing.T) {
 
 	require.NotNil(t, tq, "task queue implementation should not be nil")
 
-	id, _ := random.Generate(4) // nolint: errcheck
+	id, _ := random.Generate(8) // nolint: errcheck
 
 	// Test adding a task to a static queue
 	staticQueue := msgqueue.EVENT_PROCESSING_QUEUE

diff --git a/internal/services/worker/worker.go b/internal/services/worker/worker.go
@@ -241,7 +241,7 @@ func (w *WorkerImpl) handleStartPullRequest(ctx worker.HatchetContext) error {
 				return true
 			})
 
-			prSuffix, err := random.Generate(4)
+			prSuffix, err := random.Generate(8)
 
 			if err != nil {
 				return fmt.Errorf("could not generate random bytes: %w", err)

diff --git a/pkg/repository/github.go b/pkg/repository/github.go
@@ -47,7 +47,7 @@ func NewGithubWebhookCreateOpts(
 	repoOwner string,
 	repoName string,
 ) (opts *CreateGithubWebhookOpts, signingSecret string, err error) {
-	signingSecret, err = random.Generate(16)
+	signingSecret, err = random.Generate(32)
 
 	if err != nil {
 		return nil, "", fmt.Errorf("failed to generate signing secret: %s", err.Error())

diff --git a/pkg/repository/workflow_run.go b/pkg/repository/workflow_run.go
@@ -224,7 +224,7 @@ func GetCreateWorkflowRunOptsFromSchedule(
 }
 
 func getWorkflowRunDisplayName(workflowName string) string {
-	workflowSuffix, _ := random.Generate(3)
+	workflowSuffix, _ := random.Generate(6)
 
 	return workflowName + "-" + workflowSuffix
 }