fix(worker): deprecate On in favor of RegisterWorkflow (#627)

hatchet-dev · Jun 25, 2024 · 5ffa3d1 · 5ffa3d1
1 parent 1490d88
commit 5ffa3d1
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/pkg/worker/service.go b/pkg/worker/service.go
@@ -22,6 +22,7 @@ func (s *Service) RegisterWorkflow(workflow workflowConverter) error {
 	return s.On(workflow.ToWorkflowTrigger(), workflow)
 }
 
+// Deprecated: Use RegisterWorkflow instead
 func (s *Service) On(t triggerConverter, workflow workflowConverter) error {
 	namespace := s.worker.client.Namespace()
 

diff --git a/pkg/worker/worker.go b/pkg/worker/worker.go
@@ -237,6 +237,7 @@ func (w *Worker) RegisterWorkflow(workflow workflowConverter) error {
 	return w.On(workflow.ToWorkflowTrigger(), workflow)
 }
 
+// Deprecated: Use RegisterWorkflow instead
 func (w *Worker) On(t triggerConverter, workflow workflowConverter) error {
 	// get the default service
 	svc, ok := w.services.Load("default")