Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add haxe@^4.1 compatibility #45

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: add haxe@^4.1 compatibility #45

wants to merge 1 commit into from

Conversation

qkdreyer
Copy link

@qkdreyer qkdreyer commented Sep 9, 2020

No description provided.

@kevinresol
Copy link
Member

kevinresol commented Sep 10, 2020 •
edited
Loading

This seems to break 4.0 and 3.x, and more importantly omitted the success case.

@back2dos
Copy link
Member

Yep, this is not good. If your intention was to keep the haxe.Exception, then adding an #if (haxe_ver >= 4.1) catch (e:haxe.Exception) clause should do the trick.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qkdreyer @kevinresol @back2dos