Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix slice.limit(0) #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix slice.limit(0) #1

wants to merge 1 commit into from

Conversation

Antriel
Copy link

@Antriel Antriel commented Nov 6, 2020

No description provided.

@kevinresol
Copy link
Member

kevinresol commented Nov 7, 2020 •
edited
Loading

I think the binops are reversed for the if's
i.e. when the count is <=0 it should return empty

@Antriel
Copy link
Author

Antriel commented Nov 7, 2020

I agree, but the comment indicated otherwise, so I just fixed it to conform to the comment. I wouldn't mind the rational fix or hearing a different rationalization.

@back2dos
Copy link
Member

back2dos commented Nov 8, 2020 •
edited
Loading

Hmm, if I had to guess the comment is copy pasted from skip and I never adjusted it to make sense ^^

Edit: that and the edge cases are equally unadjusted.

@back2dos
Copy link
Member

back2dos commented Nov 8, 2020

Ok, should be fine now. Will keep this open until I have the time to write tests for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Antriel @kevinresol @back2dos