Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change dtype of ElementIdentifiers and DynamicTableRegion to int32 #85

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Change dtype of ElementIdentifiers and DynamicTableRegion to int32 #85

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
430ca15
Change dtype of ElementIdentifiers and DynamicTableRegion to int32
rly Nov 7, 2024
fd03a5c
Update hdmf_common_release_notes.rst
rly Nov 7, 2024
0ea21d4
Update version to 1.9.0-alpha
rly Nov 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion common/namespace.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ namespaces:
- doc: data types for different types of sparse matrices
source: sparse.yaml
title: Sparse data types
version: 1.8.0
version: 1.9.0-alpha

- name: hdmf-experimental
doc: Experimental data structures provided by HDMF. These are not guaranteed to be available in the future.
Expand Down
5 changes: 2 additions & 3 deletions common/table.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ datasets:
- data_type_def: ElementIdentifiers
data_type_inc: Data
default_name: element_id
dtype: int
dtype: int32
dims:
- num_elements
shape:
Expand All @@ -70,7 +70,7 @@ datasets:

- data_type_def: DynamicTableRegion
data_type_inc: VectorData
dtype: int
dtype: int32
doc: DynamicTableRegion provides a link from one table to an index or region of another. The `table` attribute is a
link to another `DynamicTable`, indicating which table is referenced, and the data is int(s) indicating the row(s)
(0-indexed) of the target array. `DynamicTableRegion`s can be used to associate rows with repeated meta-data without
Expand Down Expand Up @@ -128,7 +128,6 @@ groups:
datasets:
- name: id
data_type_inc: ElementIdentifiers
dtype: int
dims:
- num_rows
shape:
Expand Down
4 changes: 2 additions & 2 deletions docs/source/conf.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,9 +83,9 @@ def setup(app):
# built documents.
#
# The short X.Y version.
version = 'v1.8.0'
version = 'v1.9.0'
# The full version, including alpha/beta/rc tags.
release = 'v1.8.0'
release = 'v1.9.0-alpha'

# The language for content autogenerated by Sphinx. Refer to documentation
# for a list of supported languages.
Expand Down
6 changes: 6 additions & 0 deletions docs/source/hdmf_common_release_notes.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,12 @@
hdmf-common Release Notes
=========================

1.9.0 (Upcoming)
----------------------
- Change the dtype of `ElementIdentifiers` and `DynamicTableRegion` from "int" to "int32". Under the current
schema language, "int" means "int32" so this change has no functional impact, except when displaying the
spec, such as in error messages.

1.8.0 (August 4, 2023)
----------------------
- No change in the hdmf-common namespace. See :ref:`here <hdmf_experimental_release_notes>` for changes to the
Expand Down
Loading