-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create HDMF_dev.yaml #136
Create HDMF_dev.yaml #136
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #136 +/- ##
=======================================
Coverage 85.92% 85.92%
=======================================
Files 13 13
Lines 3189 3189
=======================================
Hits 2740 2740
Misses 449 449 ☔ View full report in Codecov by Sentry. |
Fix #126 |
@oruebel As I was making this, I started to think about how much did we want to test. Within tox.ini, it installs the latest release of HDMF. It will run pytest according to different environment versions. Now ideally, this workflow could do something like that, but we can't use tox.ini because we would have to edit the install requirements to use the dev branch. What I have now is a proof of concept that it works for only python 3.11. Do we want this workflow to only do that or should we get creative and test for all python versions? |
@mavaylon1 I think testing on python 3.11 (or whatever is the latest version supported by both packages) is sufficient. We could test this workflow on all python versions, on all OSs, with minimum, pinned, upgraded, and pre-release requirements, but I think that is overkill and unlikely to catch issues. |
Unlikely to catch any issues that testing on each package independently would not catch. |
Agreed. |
Since this is a workflow change, I am not updating the Changelog |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Motivation
What was the reasoning behind this change? Please explain the changes briefly.
This introduces a new workflow to run the tests on HDMF-Zarr using the dev branch of HDMF.
How to test the behavior?
Checklist
ruff
from the source directory.