Skip to content

Commit

Permalink
chckpoint
Browse files Browse the repository at this point in the history
  • Loading branch information
mavaylon1 committed Jul 31, 2024
1 parent 3b4b125 commit b251b78
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 0 deletions.
6 changes: 6 additions & 0 deletions src/hdmf/backends/hdf5/h5tools.py
Original file line number Diff line number Diff line change
Expand Up @@ -1132,6 +1132,7 @@ def write_dataset(self, **kwargs): # noqa: C901
data = builder.data
dataio = None
options = dict() # dict with additional
# breakpoint()
if isinstance(data, H5DataIO):
options['io_settings'] = data.io_settings
dataio = data
Expand Down Expand Up @@ -1488,6 +1489,11 @@ def __list_fill__(cls, parent, name, data, expandable, options=None):
data_shape = (len(data),)
else:
data_shape = get_data_shape(data)
# breakpoint()
if expandable:
# Don't override existing settings
if 'maxshape' not in io_settings:
io_settings['maxshape'] = tuple([None]*len(data_shape))

Check warning on line 1496 in src/hdmf/backends/hdf5/h5tools.py

View check run for this annotation

Codecov / codecov/patch

src/hdmf/backends/hdf5/h5tools.py#L1496

Added line #L1496 was not covered by tests

# Create the dataset
try:
Expand Down
1 change: 1 addition & 0 deletions src/hdmf/build/objectmapper.py
Original file line number Diff line number Diff line change
Expand Up @@ -722,6 +722,7 @@ def build(self, **kwargs):
if not isinstance(container, Data):
msg = "'container' must be of type Data with DatasetSpec"
raise ValueError(msg)
breakpoint()

Check warning on line 725 in src/hdmf/build/objectmapper.py

View check run for this annotation

Codecov / codecov/patch

src/hdmf/build/objectmapper.py#L725

Added line #L725 was not covered by tests
spec_dtype, spec_shape, spec_dims, spec = self.__check_dset_spec(self.spec, spec_ext)
dimension_labels = self.__get_dimension_labels_from_spec(container.data, spec_shape, spec_dims)
if isinstance(spec_dtype, RefSpec):
Expand Down

0 comments on commit b251b78

Please sign in to comment.