-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose AWS Region to HDF5IO #1040
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1040 +/- ##
==========================================
+ Coverage 88.72% 88.86% +0.14%
==========================================
Files 45 45
Lines 9766 9774 +8
Branches 2773 2776 +3
==========================================
+ Hits 8665 8686 +21
+ Misses 779 774 -5
+ Partials 322 314 -8 ☔ View full report in Codecov by Sentry. |
@oruebel Needed this PR (and probably a follow-up on PyNWB) for NWB Benchmarks @rly @mavaylon1 I added a basic test but remaining lines of coverage I have no clue how to evoke, leaving it to you to finish that coverage if you care about it |
@oruebel I think you are better suited for this PR. Can you take this one and then we talk to get me up to speed. |
@rly can you help finish up this PR? |
Review notes:
|
fix #1039
Motivation
Shows the two points of exposure required to fix this. Would be great if someone could take this PR over and properly expose it as an argument (not sure how tests should handle beyond just making sure it can pass it down...)
Also not sure why the
h5py.File
is instantiated twiceChecklist
CHANGELOG.md
with your changes?