Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore config cache warnings in sphinx #1105

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Conversation

stephprince
Copy link
Contributor

Motivation

The sphinx_gallery_conf configuration contains classes that are unpickleable and will now warn the user. This warning causes the link checker workflow to fail.

How to test the behavior?

Update sphinx and run the following:

cd docs
make clean && make html

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Does the PR clearly describe the problem and the solution?
  • Have you reviewed our Contributing Guide?
  • Does the PR use "Fix #XXX" notation to tell GitHub to close the relevant issue numbered XXX when the PR is merged?

Copy link

codecov bot commented Apr 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.70%. Comparing base (6d0be17) to head (65cc90d).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1105   +/-   ##
=======================================
  Coverage   88.70%   88.70%           
=======================================
  Files          45       45           
  Lines        9745     9745           
  Branches     2767     2767           
=======================================
  Hits         8644     8644           
  Misses        779      779           
  Partials      322      322           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mavaylon1 mavaylon1 merged commit 1f6aa5d into dev Apr 25, 2024
27 of 28 checks passed
@mavaylon1 mavaylon1 deleted the fix-sphinx-link-checker branch April 25, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants