Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete MANIFEST.in and exclude artifacts from sdist and wheel #1119

Merged
merged 4 commits into from
Jun 5, 2024
Merged

Conversation

rly
Copy link
Contributor

@rly rly commented May 22, 2024

Now that we use hatch to build instead of setuptools, and hatch has its own way of specifying which files go into the sdist/wheel, MANIFEST.in is no longer used and can be deleted.

Analogous to NeurodataWithoutBorders/pynwb#1902

Before switching to hatch, we included only certain files in the sdist/wheel (as shown in MANIFEST.in). Since switching to hatch, we include basically all files, which is unnecessary. So here I also exclude the ones we excluded previously.

Copy link

codecov bot commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.79%. Comparing base (2505a0e) to head (169b89e).
Report is 31 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1119   +/-   ##
=======================================
  Coverage   88.79%   88.79%           
=======================================
  Files          45       45           
  Lines        9774     9774           
  Branches     2776     2776           
=======================================
  Hits         8679     8679           
  Misses        778      778           
  Partials      317      317           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rly rly changed the title Delete MANIFEST.in Delete MANIFEST.in and exclude artifacts from sdist and wheel May 22, 2024
@rly rly requested a review from mavaylon1 May 22, 2024 18:46
@rly rly merged commit 5ad0beb into dev Jun 5, 2024
29 checks passed
@rly rly deleted the rly-patch-2 branch June 5, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants