Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve "already exists" error message #1165

Merged
merged 4 commits into from
Aug 19, 2024
Merged

Improve "already exists" error message #1165

merged 4 commits into from
Aug 19, 2024

Conversation

rly
Copy link
Contributor

@rly rly commented Aug 8, 2024

Motivation

The previous message was not very informative about why adding the container was not allowed.

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Does the PR clearly describe the problem and the solution?
  • Have you reviewed our Contributing Guide?
  • Does the PR use "Fix #XXX" notation to tell GitHub to close the relevant issue numbered XXX when the PR is merged?

@rly rly requested a review from mavaylon1 August 8, 2024 17:06
Copy link

codecov bot commented Aug 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.88%. Comparing base (875712b) to head (23668f8).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1165   +/-   ##
=======================================
  Coverage   88.88%   88.88%           
=======================================
  Files          45       45           
  Lines        9835     9835           
  Branches     2795     2795           
=======================================
  Hits         8742     8742           
  Misses        776      776           
  Partials      317      317           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mavaylon1 mavaylon1 enabled auto-merge (squash) August 19, 2024 13:16
@mavaylon1 mavaylon1 merged commit 2f339d1 into dev Aug 19, 2024
27 of 28 checks passed
@mavaylon1 mavaylon1 deleted the improve_error branch August 19, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants