Check DynamicTableRegion data is in bounds #1168
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #1168 +/- ##
==========================================
- Coverage 88.89% 85.65% -3.24%
==========================================
Files 45 45
Lines 9834 9853 +19
Branches 2794 2802 +8
==========================================
- Hits 8742 8440 -302
- Misses 776 1076 +300
- Partials 316 337 +21 ☔ View full report in Codecov by Sentry. |
oruebel
reviewed
Aug 11, 2024
Comment on lines
+1419
to
+1420
| for val in self.data: | ||
| self._validate_new_data_element(val) |
There was a problem hiding this comment.
You might want to try this as a list comprehension [self._validate_new_data_element(val) for val in self.data] just because they tend to be faster in Python than regular for loops
oruebel
reviewed
Aug 11, 2024
Comment on lines
+1390
to
+1393
| for val in data: | ||
| if val >= len(table) or val < 0: | ||
| error_msg = f"DynamicTableRegion index {val} is out of bounds for {type(table)} '{table.name}'." | ||
| self._error_on_new_warn_on_construct(error_msg, error_cls=IndexError) |
There was a problem hiding this comment.
Instead of iterating through all the values, I think checking for np.max(data) >= len(table) would be more efficient.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix #210
Checklist
CHANGELOG.mdwith your changes?