-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DynamicEnums and Schemasheets integration #923
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Co-authored-by: Oliver Ruebel <[email protected]>
Co-authored-by: Oliver Ruebel <[email protected]>
Co-authored-by: Oliver Ruebel <[email protected]>
Co-authored-by: Oliver Ruebel <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall the PR looks good. I added a few comments below, but those should all be easy/quick to fix.
I really appreciate it! I made most of the changes, but also I left some notes to clarify some the methods both here and in the docstring as to why it is setup the way it is. |
Motivation
What was the reasoning behind this change? Please explain the changes briefly.
Currently to create a TermSet a user has to manually add the permissible values to the enumeration. This is not scalable and so we want to take advantage of the LinkML tools that should make creating schemas easier.
The goal of this PR is to add support for
How to test the behavior?
Run the unit tests.
Checklist
ruff
from the source directory.