Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DynamicEnums and Schemasheets integration #923

Merged
merged 90 commits into from
Aug 13, 2023
Merged

DynamicEnums and Schemasheets integration #923

merged 90 commits into from
Aug 13, 2023

Conversation

mavaylon1
Copy link
Contributor

@mavaylon1 mavaylon1 commented Jul 28, 2023

Motivation

What was the reasoning behind this change? Please explain the changes briefly.

Currently to create a TermSet a user has to manually add the permissible values to the enumeration. This is not scalable and so we want to take advantage of the LinkML tools that should make creating schemas easier.
The goal of this PR is to add support for

  • LinkML schemasheets in TermSet
  • LinkML integration for Dynamic TermSet
  • Updated documentation

How to test the behavior?

Show how to reproduce the new behavior (can be a bug fix or a new feature)

Run the unit tests.

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running ruff from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@mavaylon1 mavaylon1 marked this pull request as ready for review August 13, 2023 03:08
src/hdmf/term_set.py Outdated Show resolved Hide resolved
src/hdmf/term_set.py Outdated Show resolved Hide resolved
src/hdmf/term_set.py Outdated Show resolved Hide resolved
src/hdmf/term_set.py Outdated Show resolved Hide resolved
src/hdmf/term_set.py Outdated Show resolved Hide resolved
mavaylon1 and others added 2 commits August 13, 2023 12:37
Co-authored-by: Oliver Ruebel <[email protected]>
Co-authored-by: Oliver Ruebel <[email protected]>
Co-authored-by: Oliver Ruebel <[email protected]>
Copy link
Contributor

@oruebel oruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall the PR looks good. I added a few comments below, but those should all be easy/quick to fix.

@mavaylon1
Copy link
Contributor Author

Overall the PR looks good. I added a few comments below, but those should all be easy/quick to fix.

I really appreciate it! I made most of the changes, but also I left some notes to clarify some the methods both here and in the docstring as to why it is setup the way it is.

@mavaylon1 mavaylon1 requested a review from oruebel August 13, 2023 20:18
src/hdmf/term_set.py Outdated Show resolved Hide resolved
@mavaylon1 mavaylon1 merged commit 8376a6a into dev Aug 13, 2023
24 of 25 checks passed
@rly rly deleted the enums branch August 14, 2023 21:14
@rly rly mentioned this pull request Aug 15, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants