-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
frontend: Adds filter feature for app catalog #43
Conversation
3b82180
to
7e7a7d2
Compare
-- the last push
|
currently the issue is that we do not render anything that does not match the search parameters (that are currently set on a default) so charts that are not verified or official do not show up this is tricky as we use the facets object from the api response to use for our displayed charts and pages navigation |
3355c82
to
efbcd61
Compare
efbcd61
to
f2f4f25
Compare
Previous pushFixed
Next
|
f2f4f25
to
36db7cd
Compare
Previous pushFixed
To do
|
36db7cd
to
137eb23
Compare
Previous pushFixed
To do
|
137eb23
to
41fefd6
Compare
Prev push bug fixesNext
Done
|
41fefd6
to
894e933
Compare
Prev push feat progressDone
|
894e933
to
a538a85
Compare
Push note
|
a538a85
to
cef9f8f
Compare
Note
|
cef9f8f
to
92c5661
Compare
moving to WIP until solution for the response header proxy is in |
@sniok
When running 'dev-only-app' our localhost is set to 3000 via ELECTRION_START_URL within the 'dev-only-app' script and we hit a cors wall which does not provide the header for pagination total count If the app mode is ran with 'npm run dev' the origin is not set to localhost 3000 and cors does not apply
This means it will not work with 'npm run start' and 'npm run dev only app' but for production and 'npm run dev' it will |
92c5661
to
d888391
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed a couple of things that could be in separate commits and left notes for them.
Maybe you know of some other things that can be atomic commits as well?
e7fb884
to
02cb35e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some notes about adding these components in separate files and in separate commits.
9055ef1
to
47e36a8
Compare
hey hey. I just noticed the commit messages messages need mending:
Use
|
68a7c15
to
3dc499a
Compare
Should be the right way now! |
Awesome & thanks. |
3dc499a
to
620758d
Compare
Signed-off-by: Vincent T <[email protected]>
Signed-off-by: Vincent T <[email protected]>
Signed-off-by: Vincent T <[email protected]>
Signed-off-by: Vincent T <[email protected]>
Signed-off-by: Vincent T <[email protected]>
Signed-off-by: Vincent T <[email protected]>
Signed-off-by: Vincent T <[email protected]>
Signed-off-by: Vincent T <[email protected]>
Signed-off-by: Vincent T <[email protected]>
620758d
to
f6bc7eb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 thanks
Add Filter for Verified and Official Apps in App Catalog
Description
Fixes Issue #21
This PR introduces a new filter in the app catalog that allows users to choose whether to display apps based on their verification and official status. By default, the app catalog will only show apps that are verified and official, enhancing security and ensuring that users are installing trusted applications. Users can use the new filter to include apps that are not verified or official if needed.
Changes
Verification
Screenshots