Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added compatibility with osx #284

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

xmnlab
Copy link
Contributor

@xmnlab xmnlab commented Oct 30, 2018

In this PR:

  • Changed /bin/bash to /usr/bin/env bash to allow bash from conda. This script need new bash, osx bash default is older that bash used by linux by default.
  • Changed id to whoami command line to keep compatibility with osx
  • Added SYSTEMD_PATH variable

@xmnlab
Copy link
Contributor Author

xmnlab commented Oct 30, 2018

cc @tonyfast

@andrewseidl
Copy link
Contributor

Thanks @xmnlab !

What do you plan on using this for? systemd only exists on Linux, which is why there are a few Linux-isms in there. We might want a separate script for macOS with defaults for that platform.

@xmnlab
Copy link
Contributor Author

xmnlab commented Oct 30, 2018

Oh I see ... I didn't know that ... thanks for the explanation! I just know that it doesn't work inside a docker container.

What do you plan on using this for? systemd only exists on Linux, which is why there are a few Linux-isms in there.

Actually I was not planning to use systemd (because it doesn't work inside docker container) I just planned to change this script and allow it to run in macos environment (called from any folder) and on the conda build task I will comment via sed the line with sudo systemctl daemon-reload

We might want a separate script for macOS with defaults for that platform.

I see ... do you want to keep any of these changes in this PR?

for macOS, should I create a similar file but without the systemd stuff?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants