Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge 'master' with 'test-suite' #3470

Open
wants to merge 332 commits into
base: test-suite
Choose a base branch
from

Conversation

subhojit777
Copy link
Contributor

No description provided.

timplunkett and others added 30 commits December 17, 2016 15:12
…hoendrupal#3007)

Use $this->appRoot, $this->root is empty, which breaks
example.sites.php -file test.
* Add logic to enable multisite installation

* Enable multisite command if Drupal is not installed
Sites may want to replace the default password service (e.g. to use a wrapper around password_hash() and friends).
* [database:dump] Don't duplicate .gz extension

* [database:dump] Keep the overwritten file
* Adding template folder and file creation to generate module command.

* Undoing un needed changes.

* Undoing un needed changes.

* Formatting changes.
* working disable cache page in site:mode dev

* added --local option for keeping settings.local.php and testing PROD in local
…return on configImport method for config:import:single command (hechoendrupal#2965)

* Fix configImport not returning boolean

* Added new config:import:list and config:export:list commands

* Small adjustements

* Added possibility to use absolute or relative to drupal root path for directory and config-list-file parameter/argument

* Added ability to use chain command for importing or exporting multiple configs with the config:import:single and config:export:single commands
* [site:new] Remove command.

* [site:mode] Disable command.
* [console] Show error on command registration  error.

* [config:export:single] Multiple fixes and improvements

* [config:import:single] Multiple fixes and improvements
* Update FormAlterGenerator.php

* Update AuthenticationProviderGenerator.php

* Update BreakPointGenerator.php

* Update EntityBundleGenerator.php

* Update EntityConfigGenerator.php

* Update ControllerGenerator.php

* Update EntityContentGenerator.php

* Update EventSubscriberGenerator.php

* Update FormGenerator.php

* Update PluginConditionGenerator.php

* Update PluginCKEditorButtonGenerator.php

* Update HelpGenerator.php

* Update PluginViewsFieldGenerator.php

* Update UpdateGenerator.php

* Update TwigExtensionGenerator.php

* Update ThemeGenerator.php

* Update ServiceGenerator.php

* Update RouteSubscriberGenerator.php

* Update PostUpdateGenerator.php
* [config:export:single] Update translation key.

* Remove translations directory.
…3030)

* Extend from RevisionLogInterface. Replace several deprecated *RevisionAuthor* functions.

* Replace several deprecated *RevisionAuthor* functions.

* Add missing dependency.
… line (hechoendrupal#3036)

When passing profile or machine-name on the command line like that:

  drupal generate:profile --profile=PROFILE --machine-name=MACHINE_NAME

drupal console gives an error:

Error: Call to undefined method Drupal\Console\Command\Generate\ProfileCommand::validateModuleName() in Drupal\Console\Command\Generate\ProfileCommand->interact() (line 234 of .../vendor/drupal/console/src/Command/Generate/ProfileCommand.php).

After fixing this another similar error shows up:

Error: Call to undefined method Drupal\Console\Command\Generate\ProfileCommand::validateModule() in Drupal\Console\Command\Generate\ProfileCommand->interact() (line 253 of .../vendor/drupal/console/src/Command/Generate/ProfileCommand.php).

Fix both so that the command line from above works again.

Closes hechoendrupal#3035
There are question strings defined but they aren't used, unlike in other plugin generation commands.
…pal#3044)

- config:validate overrides the parent constructor's optional
  name argument with a constructor that requires it.

- generate:module requires an argument that is not defined in
  the corresponding services file, and should be optional.
jmolivas and others added 22 commits July 14, 2017 02:18
* Replacing in translation key from _ to -

* Adding translation messages for the commands:
config
module:install
taxonomy:term:delete
* EntityContentGenearator should store *.page.inc in module root directory, not /src

* Remove extraneous space in 'con struct' causing errors with generated templates'
* Replacing in translation key from _ to -

* Adding translation messages for the commands:
config
module:install
taxonomy:term:delete

* Adding translation to config, edit and theme commands

* Adding devel translations

* Adding translations for generate command

* Adding forgotten translation

* Adding another forgotten translation
Set constraint to minimum minor version, so that PHP 5.6+ environments can use
newer minor versions.
Drupal 8.4 updates Symfony component requirements to ~3.2, so will conflict
with a ~2.8 requirement.
* [console] Extend base commands.

* [console] Extend command base (hechoendrupal#3458)

* [console] Extend base commands. (hechoendrupal#3457)

* [console] Extend base commands
@joshirohit100
Copy link
Contributor

This looks like hell of a change 😁

@jmolivas jmolivas modified the milestone: 1.0.0-fixes Aug 4, 2017
@jmolivas
Copy link
Member

@subhojit777 I saw many files updated to sure if correct I will try to replicate on my local

@subhojit777
Copy link
Contributor Author

@jmolivas I saw that the stable release now has tests. How this branch is different from the tests already in master.

@enzolutions
Copy link
Contributor

@subhojit777 this is still a work that you would be interested in complete?

@subhojit777
Copy link
Contributor Author

@enzolutions I am afraid I will not be able to work on this. I am already neck deep in work and learning Rust.

However, I have asked in my organization if anybody would be interested to work on this.

Can you tell me what's left? What needs to be done to complete this?

@enzolutions
Copy link
Contributor

Firstly, If you could define the goal and what you did, I could start to try to help in this area. I am totally blind here.

Good luck with your learning of Rust.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.