Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] main from bazelbuild:master #450

Open
wants to merge 1,626 commits into
base: main
Choose a base branch
from
Open
This pull request is big! We’re only showing the most recent 250 commits.

Commits on Oct 8, 2024

  1. Configuration menu
    Copy the full SHA
    8eeef39 View commit details
    Browse the repository at this point in the history
  2. Update changelog for v2024.10.08 release (#6859)

    * Update changelog for v2024.10.08 release
    
    Please let me know of any important changes that you want to make visible by adding to the Change log.
    
    * Update changelog for v2024.10.08 release
    
    * Update CHANGELOG
    
    ---------
    
    Co-authored-by: Mai Hussien <[email protected]>
    satyanandak and mai93 authored Oct 8, 2024
    Configuration menu
    Copy the full SHA
    26e7bc1 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2024

  1. chore: copy some aspect files to the client side to prepare for templ…

    …ating (#6842)
    
    * [maintenance] copy java_info.bzl to project side to prepare for templating it.
    
    * rename local path
    
    * refactor a few files that use `override_repository`
    
    * abc
    
    * abc
    
    * revert change
    
    * revert changes
    
    * fix error for clion
    
    * attempt to fix aspect test
    
    * update clwb BUILD file + fix ijwb visibility typo
    
    * updated logic
    
    * disable tests
    
    * update logic
    
    * mute tests
    xuansontrinh authored Oct 9, 2024
    Configuration menu
    Copy the full SHA
    893eaa8 View commit details
    Browse the repository at this point in the history
  2. SyncListener for aspect templating (#6871)

    * moved aspect templating code to SyncListener
    
    Also took the liberty to add proper error handling while doing so.
    
    * fixed ijwb integration tests
    LeFrosch authored Oct 9, 2024
    Configuration menu
    Copy the full SHA
    ea47578 View commit details
    Browse the repository at this point in the history
  3. Upgrade protobuf and load proto_library and lang_proto_library from it (

    #6862)
    
    * Upgrade everything! [
    
    (cherry picked from commit 19aa952)
    
    * Rename com_google_protobuf to protobuf
    
    (cherry picked from commit b220447)
    
    * Fix for recent protobuf dep
    
    * Change rules_proto loads to protobuf
    
    (cherry picked from commit 65c4b02)
    
    * Replace lang_proto_libraries with loads from protobuf
    
    (cherry picked from commit ffe44b6)
    
    * fix
    
    ---------
    
    Co-authored-by: Xdng Yng <[email protected]>
    Co-authored-by: Googler <[email protected]>
    3 people authored Oct 9, 2024
    Configuration menu
    Copy the full SHA
    0bdafa1 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2024

  1. Configuration menu
    Copy the full SHA
    21343f0 View commit details
    Browse the repository at this point in the history
  2. [fix] Fix python debugging (#6847)

    * [fix] Fix python debugging
    
    * Format
    
    * Logging
    
    * Annotation
    agluszak authored Oct 10, 2024
    Configuration menu
    Copy the full SHA
    41e93fc View commit details
    Browse the repository at this point in the history
  3. Download Buildifier Binary (#6625)

    Adds support to automatically download the buildifier binary if it is not installed.
    LeFrosch authored Oct 10, 2024
    Configuration menu
    Copy the full SHA
    5ac22de View commit details
    Browse the repository at this point in the history
  4. Support for Python Rules that are Code Generators (#6726)

    * Implement py code generation handling
    
    It is possible to write Bazel rules that generate Python code and
    act as a `py_library`. The plugin is augmented with this change to
    have a means of detecting these sort of rules and be able to work
    with them.
    
    * Implement py code generation handling - fix method signature problem
    
    It is possible to write Bazel rules that generate Python code and
    act as a `py_library`. The plugin is augmented with this change to
    have a means of detecting these sort of rules and be able to work
    with them.
    andponlin-canva authored Oct 10, 2024
    Configuration menu
    Copy the full SHA
    8ebed93 View commit details
    Browse the repository at this point in the history
  5. fix: Re-realize aspect files after plugin update (#6872)

    * fix: Re-realize aspect files after plugin update
    
    * fix test
    
    * chore: Disable CLion 2022.3 tests
    
    * apply review comments
    
    * Throw if not aspect template dir
    tpasternak authored Oct 10, 2024
    Configuration menu
    Copy the full SHA
    7c8d1f5 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2024

  1. Configuration menu
    Copy the full SHA
    f7c5458 View commit details
    Browse the repository at this point in the history
  2. Update querysync.md (#6881)

    * Update querysync.md
    
    * Update querysync.md
    tpasternak authored Oct 11, 2024
    Configuration menu
    Copy the full SHA
    034175e View commit details
    Browse the repository at this point in the history
  3. Set runfiles vars to absolute paths when debugging Go tests (#6883)

    Otherwise they will be incorrectly interpreted relative to the modified working directory.
    fmeum authored Oct 11, 2024
    Configuration menu
    Copy the full SHA
    017e063 View commit details
    Browse the repository at this point in the history
  4. fix: Disable python codegen support by default (#6884)

    * fix: Disable python codegen support by default
    
    * fix: Disable python codegen support by default
    
    * Update EnablePythonCodegenSupport.java
    tpasternak authored Oct 11, 2024
    Configuration menu
    Copy the full SHA
    7ba94e2 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2024

  1. chore: Bump CLion (#6890)

    LeFrosch authored Oct 14, 2024
    Configuration menu
    Copy the full SHA
    ac627ad View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    72529f0 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    711519d View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2024

  1. Configuration menu
    Copy the full SHA
    3c0d903 View commit details
    Browse the repository at this point in the history
  2. Update CLion and IntelliJ test configurations (#6856)

    * ci: remove google internal testconfigs
    
    they point to a very old version and we do
    not receive updates from google, neither google
    receives from us
    
    * ci: add clion configurations for os and ls
    
    our main target configurations so we'd like
    to test against them
    
    * ci: fix typo in intellijce test config name
    ujohnny authored Oct 15, 2024
    Configuration menu
    Copy the full SHA
    2f24ed2 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2024

  1. doc: Document the starlark debugger (#6899)

    * doc: Document the starlark debugger
    
    * Update starlark_debugger.md
    tpasternak authored Oct 16, 2024
    Configuration menu
    Copy the full SHA
    30b7a7a View commit details
    Browse the repository at this point in the history
  2. Update querysync.md (#6898)

    * Update querysync.md
    
    * Update querysync.md
    tpasternak authored Oct 16, 2024
    Configuration menu
    Copy the full SHA
    b823456 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c1bfa06 View commit details
    Browse the repository at this point in the history
  4. doc: Document hotswapping (#6902)

    * doc: Document hotswapping
    
    * Update hotswap.md
    tpasternak authored Oct 16, 2024
    Configuration menu
    Copy the full SHA
    36ed4c1 View commit details
    Browse the repository at this point in the history
  5. doc: Document fast builds (#6904)

    * doc: Document fast builds
    
    * Update fastbuild.md
    
    * Update fastbuild.md
    
    * Update fastbuild.md
    
    * Update fastbuild.md
    tpasternak authored Oct 16, 2024
    Configuration menu
    Copy the full SHA
    1e071bb View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    d8bca87 View commit details
    Browse the repository at this point in the history
  7. doc: Table of contents (#6905)

    * doc: Table of contents
    
    * Update index.md
    tpasternak authored Oct 16, 2024
    Configuration menu
    Copy the full SHA
    a1cf27c View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2024

  1. Configuration menu
    Copy the full SHA
    12a7d81 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5ba2eac View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2024

  1. Decorate tabs for BUILD files with package name (#6900)

    Since BUILD files all have the same name it's hard
    to distinguish them, so we can use EditorTabTitleProvider
    to write full label in the editor tab title
    ujohnny authored Oct 18, 2024
    Configuration menu
    Copy the full SHA
    94b38b5 View commit details
    Browse the repository at this point in the history
  2. New Sync View (#6813)

    Adds a new sync view that uses the build view provided by platform. Error messages received by BEP rather than parsing the command line output to increase the quality and relevance of reported errors. Currently the view is disabled by default but can be enabled in the settings.
    LeFrosch authored Oct 18, 2024
    Configuration menu
    Copy the full SHA
    c1a3c5a View commit details
    Browse the repository at this point in the history
  3. Python code-gen; rename query methods (#6887)

    The class `TargetTagFilter` is about filtering targets
    by tag and is agnostic about its use for the code-gen
    filtering. This commit renames the methods to make this
    more obvious.
    andponlin-canva authored Oct 18, 2024
    Configuration menu
    Copy the full SHA
    d8928b9 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    9cebd40 View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2024

  1. Configuration menu
    Copy the full SHA
    160a88e View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2024

  1. Configuration menu
    Copy the full SHA
    a285c99 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    dd3636f View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2024

  1. Configuration menu
    Copy the full SHA
    9777156 View commit details
    Browse the repository at this point in the history
  2. Allow all characters in runfile source and target paths [

    (cherry picked from commit 1f907ad)
    fmeum authored and mai93 committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    13955e3 View commit details
    Browse the repository at this point in the history
  3. Add FileDependencySerializer.

    Performs serialization of leaf-level FileValue and DirectoryListingValue
    dependencies using the schema defined in file_invalidation_data.proto.
    
    The logical flow mirrors that of FileFunction.
    
    This is intended for use during serialization, where there is a
    high degree of concurrency and many nodes may share the same file
    dependencies.
    
    (cherry picked from commit f5f6a7a)
    Googler authored and mai93 committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    c0e3337 View commit details
    Browse the repository at this point in the history
  4. Drop FileInvalidationData.type.

    It's not the case that if we have DirectoryListingInvalidationData that
    we will have all the corresponding FileInvalidationData for the contents
    of that directory.
    
    We'll use an overly-conservative approach ond invalidate the
    DirectoryListingValue if any of its contents change. It's suboptimal
    but still correct. We could at a later point persist the dirent types
    from the DirectoryListingValue if this approximation is problematic.
    
    (cherry picked from commit 562b076)
    Googler authored and mai93 committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    a9fdb25 View commit details
    Browse the repository at this point in the history
  5. Automatic code cleanup.

    (cherry picked from commit ac8d6be)
    Googler authored and mai93 committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    68c1797 View commit details
    Browse the repository at this point in the history
  6. Automatic code cleanup.

    (cherry picked from commit c14afe0)
    Googler authored and mai93 committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    7e7fd56 View commit details
    Browse the repository at this point in the history
  7. Update changelog for v2024.10.22 release (#6920)

    * Update changelog for v2024.10.22 release
    satyanandak authored Oct 22, 2024
    Configuration menu
    Copy the full SHA
    77b7a71 View commit details
    Browse the repository at this point in the history
  8. chore: bump CLion (#6921)

    LeFrosch authored Oct 22, 2024
    Configuration menu
    Copy the full SHA
    6ce4d4e View commit details
    Browse the repository at this point in the history
  9. Use execroot for compiler working directory (#6911)

    Compiler is no longer run in the repository root but in the exec root. This is required for some custom toolchains because dependencies cannot be accessed from the repository root.
    LeFrosch authored Oct 22, 2024
    Configuration menu
    Copy the full SHA
    0c77e97 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    3a40e4c View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2024

  1. Configuration menu
    Copy the full SHA
    1d14ae1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3e5835d View commit details
    Browse the repository at this point in the history
  3. Do not decorate tabs for BUILD files in non-bazel projects (#6925)

    If a project isn't imported then do not try to decorate
    as otherwise tab name has a full path to file.
    ujohnny authored Oct 23, 2024
    Configuration menu
    Copy the full SHA
    665b54e View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2024

  1. Configuration menu
    Copy the full SHA
    2ebf847 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2024

  1. CLion support for cc_library implementation deps (#6919)

    Adds support for the implementation_deps field from cc_library. Closes #5149
    LeFrosch authored Oct 25, 2024
    Configuration menu
    Copy the full SHA
    1f14091 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    769797d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    26c2a5c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    76f1972 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2024

  1. feat: Query Sync for Python 1/n - non-analysis mode (#6879)

    Co-authored-by: Andrzej Głuszak <[email protected]>
    tpasternak and agluszak authored Oct 28, 2024
    Configuration menu
    Copy the full SHA
    a13a812 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a8e7eb0 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6ce43ed View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2024

  1. Supply code-gen rule names via settings (#6889)

    * Supply code-gen rule names via settings
    
    A prior PR has allowed that, for some languages, certain
    Rules may be specified as being "code generators". This
    mechanism was via Bazel tags on the target. This commit
    changes the mechanism so that the rule names are specified
    by settings instead.
    
    * Supply code-gen rule names via settings (fix android test)
    
    * Supply code-gen rule names via settings (fix android test 2)
    
    * switch the detection of code-gen rule names to action env
    
    * switch the detection of code-gen rule names to action env - comments corrections
    
    * Revert "switch the detection of code-gen rule names to action env - comments corrections"
    
    This reverts commit bffe170.
    
    * Revert "switch the detection of code-gen rule names to action env"
    
    This reverts commit e1e9bd0.
    
    * switch to use .bzl templates to convey the languages' rules' names to the aspect
    
    * switch to use .bzl templates to convey the languages' rules' names to the aspect - fix android test
    andponlin-canva authored Oct 29, 2024
    Configuration menu
    Copy the full SHA
    22a4474 View commit details
    Browse the repository at this point in the history
  2. fix(qsync): Enable basic syntax highlighting in 'analysis disabled' m…

    …ode (#6941)
    
    * fix(qsync): Enable basic syntax highlighting in 'analysis disabled' mode
    
    * fix(qsync): Less configsing registry key
    
    * Fix xml tag in blaze-base.xml
    tpasternak authored Oct 29, 2024
    Configuration menu
    Copy the full SHA
    13b1799 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2024

  1. Configuration menu
    Copy the full SHA
    8036598 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0f0f910 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a041f5e View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2024

  1. Configuration menu
    Copy the full SHA
    1415d1b View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2024

  1. CLion external include support (#6922)

    Adds support for external includes by forwarding all external_includes from the compilation context to system includes, since they are treated the same. Closes #4980
    LeFrosch authored Nov 4, 2024
    Configuration menu
    Copy the full SHA
    6eba3a5 View commit details
    Browse the repository at this point in the history
  2. fix: Python tests (#6954)

    * fix: Python tests
    
    * fix: Python tests for CE
    tpasternak authored Nov 4, 2024
    Configuration menu
    Copy the full SHA
    06bdbb5 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    003a740 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    115ce91 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    581723b View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2024

  1. Configuration menu
    Copy the full SHA
    8d910d6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c7cd1df View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a51558f View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2024

  1. Reimplement --quiet using a field in the command server proto.

    Rearguard fighting for #4867.
    
    RELNOTES: None.
    (cherry picked from commit 0b5f8d9)
    Googler authored and mai93 committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    06fddd4 View commit details
    Browse the repository at this point in the history
  2. Reporting skipped test cases [

    (cherry picked from commit 4ff0f69)
    linzhp authored and mai93 committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    f01c878 View commit details
    Browse the repository at this point in the history
  3. Add HOME TO PathToReplace#Type enumeration

    (cherry picked from commit 9911b45)
    Googler authored and mai93 committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    f746b25 View commit details
    Browse the repository at this point in the history
  4. Automatic code cleanup.

    (cherry picked from commit 15a700f)
    Googler authored and mai93 committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    721e645 View commit details
    Browse the repository at this point in the history
  5. Use aspect to toolchain propagation to collect information of Cc and …

    …Kotlin toolchains
    
    the `_toolchain` attribute is removed by `rules_kotlin` and `_cc_toolchain` attribute is planned to be removed by `rules_cc`. This change uses the new approach of aspect to toolchains propagation based on toolchain types instead. This feature is available in Blaze but not in all Bazel versions. Therefore, we keep using the old attribute-based approach for Bazel as the toolchain attributes will still be there for Bazel.
    
    (cherry picked from commit 7e7f940)
    mai93 committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    12aee7e View commit details
    Browse the repository at this point in the history
  6. Fix CI failures

    Modify copybara to get proto rules from protobuf
    
    (cherry picked from commit be5aa2e)
    mai93 committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    ba3e215 View commit details
    Browse the repository at this point in the history
  7. Remove duplicate deps

    mai93 committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    46e1c69 View commit details
    Browse the repository at this point in the history
  8. Fix flag name referenced in build_event_stream.proto.

    The BEP may now be configured to report files inline in the `TargetComplete`
    event on a per-output group basis, if the flag
    `--experimental_build_event_output_group_mode` is set appropriately.  The
    `.proto` file references the correct flag name now.
    
    h/t to @sluongng for pointing out this discrepancy.
    
    RELNOTES: n/a
    (cherry picked from commit c4431be)
    Googler authored and mai93 committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    b0eb9e2 View commit details
    Browse the repository at this point in the history
  9. Remove tests failing at HEAD that run on TAP

    (cherry picked from commit d462c33)
    Googler authored and mai93 committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    a7190bf View commit details
    Browse the repository at this point in the history
  10. fix(qsync): Unhandled exception when trying to resolve external works…

    …pace labels (#6962)
    
    For now, we have to just disable that.
    
    closes #6961
    tpasternak authored Nov 6, 2024
    Configuration menu
    Copy the full SHA
    4b8c6d7 View commit details
    Browse the repository at this point in the history
  11. fix(qsync): NPE in "Add to project" panel action (#6967)

    A comment contains a warning that there should be at least two packages
    found in order to provide user a choice. However in some cases there
    is only a single package to add.
    
    For this reason, we stop the lookup if it reaches project root,
    but we don't add a package automatically, so a user can always reject
    the change.
    
    closes #6966
    tpasternak authored Nov 6, 2024
    Configuration menu
    Copy the full SHA
    c63414c View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2024

  1. Update changelog for v2024.11.05 release (#6952)

    * Update changelog for v2024.11.05 release
    satyanandak authored Nov 7, 2024
    Configuration menu
    Copy the full SHA
    95b750b View commit details
    Browse the repository at this point in the history
  2. Use bazel icon for plugin logo (#6973)

    * Use bazel icon for plugin logo
    
    We'd like to make plugin more discoverable in the
    search output on the marketplace and also make its tile
    look nice on the staff-picked plugins page.
    
    approved by @meisterT by email
    
    * Adjust icon size
    
    Marketplace and IntelliJ platform require
    40x40 size
    
    * Minor adjustment from designer after rough resizing
    
    Removed some pixelness on the sides when scaled to 40x40
    ujohnny authored Nov 7, 2024
    Configuration menu
    Copy the full SHA
    bd5aa64 View commit details
    Browse the repository at this point in the history
  3. 2024.3 update for plugins (#6977)

    * 2024.3 update for plugins
    
    switch from 241 + 242 to 242 + 243
    
    * clion: update SDK to 2024.3 Beta
    ujohnny authored Nov 7, 2024
    Configuration menu
    Copy the full SHA
    d519597 View commit details
    Browse the repository at this point in the history
  4. Fixes issues when bazel is used alongside cmake (#6770)

    * fixed multiple registrations
    
    * fixed notification show for files in a different project model
    
    * Rename .java to .kt
    
    * changes for 243
    
    * added read action
    
    * created service for CLionNotificationProvider
    
    * added psw status to simple integration test
    
    * Revert "added psw status to simple integration test"
    
    This reverts commit c2906ad.
    
    Let's wait with this until we drop 241. Don't want to introduce sdk compat for tests.
    LeFrosch authored Nov 7, 2024
    Configuration menu
    Copy the full SHA
    8ae4e23 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2024

  1. Use --noincompatible_disallow_empty_glob (#6936)

    * Update .bazelrc
    
    * Update .bazelversion
    mai93 authored Nov 8, 2024
    Configuration menu
    Copy the full SHA
    5ac32ee View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    fac06d1 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    bb2c011 View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2024

  1. Configuration menu
    Copy the full SHA
    d026c92 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    297e4d2 View commit details
    Browse the repository at this point in the history
  3. chore: Bump JetBrains IDEs (#6978)

    Co-authored-by: Mai Hussien <[email protected]>
    tpasternak and mai93 authored Nov 12, 2024
    Configuration menu
    Copy the full SHA
    f820249 View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2024

  1. Configuration menu
    Copy the full SHA
    b3eea97 View commit details
    Browse the repository at this point in the history
  2. fix: Support bazel 8 and --noenable_workspace mode (#6990)

    * fix: Support bazel 8 and `--noenable_workspace` mode
    
    closes #6984
    tpasternak authored Nov 13, 2024
    Configuration menu
    Copy the full SHA
    fc3990b View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2024

  1. Configuration menu
    Copy the full SHA
    48f7ac5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2a83d56 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    7292aab View commit details
    Browse the repository at this point in the history
  4. Revert "fix: Support bazel 8 and --noenable_workspace mode (#6990)" (

    …#6997)
    
    This reverts commit fc3990b.
    
    We have to wait until bazel8 rc3
    tpasternak authored Nov 14, 2024
    Configuration menu
    Copy the full SHA
    b3cb634 View commit details
    Browse the repository at this point in the history
  5. Fix querysync widget for remote dev (#6996)

    * Fix querysync widget for remote dev
    
    * Fix
    agluszak authored Nov 14, 2024
    Configuration menu
    Copy the full SHA
    2bbe4de View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2024

  1. Fixed Java enabled condition in SyncAspectTemplateProvider (#6987)

    Removed the check for GENERIC language class when determining if Java is enabled. This change ensures that only the presence of JAVA language class sets the "isJavaEnabled" flag to true.
    LeFrosch authored Nov 15, 2024
    Configuration menu
    Copy the full SHA
    353dac8 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2024

  1. Configuration menu
    Copy the full SHA
    97e55ff View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2024

  1. Configuration menu
    Copy the full SHA
    5fe7245 View commit details
    Browse the repository at this point in the history
  2. fix: Properly support non-Java Bazel 8 projects in IntelliJ (#7006)

    Previously, the condition to load rules_java was based on the "additional languages" field,
    which led to issues as Java is always present in IntelliJ (unlike PyCharm).
    This change modifies the condition to explicitly check if rules_java
    is actually loaded in the project, ensuring proper handling of non-Java projects in IntelliJ.
    tpasternak authored Nov 19, 2024
    Configuration menu
    Copy the full SHA
    373eb7a View commit details
    Browse the repository at this point in the history
  3. feat: Starlark Debugger Gutter Icons (#6999)

    * feat: Starlark Debugger Gutter Icons
    tpasternak authored Nov 19, 2024
    Configuration menu
    Copy the full SHA
    fda4bb2 View commit details
    Browse the repository at this point in the history
  4. Update README.md (#6988)

    mai93 authored Nov 19, 2024
    Configuration menu
    Copy the full SHA
    4d52920 View commit details
    Browse the repository at this point in the history
  5. Replace calls to ServiceManager.getService for application and modules

    PiperOrigin-RevId: 526659280
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    c045170 View commit details
    Browse the repository at this point in the history
  6. Implement working set derivation from PROJECT.scl.

    This allows project owners to denote the owned code paths for their project, creating a boundary of project-internal and project-external paths.
    
    PiperOrigin-RevId: 640042104
    jin authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    b9fd547 View commit details
    Browse the repository at this point in the history
  7. Add a utility method for getting a singleton package path.

    PiperOrigin-RevId: 643108098
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    038998a View commit details
    Browse the repository at this point in the history
  8. Add missing category submessage.

    Fixes #22741.
    
    PiperOrigin-RevId: 643932127
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    7b82e4e View commit details
    Browse the repository at this point in the history
  9. Imported changes from initial AOSP commit

    AOSP: 7048e6ff6c860de1f4ae0789b09ac81fa85e3845
    
    # Conflicts:
    #	base/src/META-INF/blaze-base.xml
    #	querysync/javatests/com/google/idea/blaze/qsync/TestDataSyncRunner.java
    #	shared/java/com/google/idea/blaze/common/Label.java
    LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    a88c6db View commit details
    Browse the repository at this point in the history
  10. IJWB compatability fixes

    - removed fast build from ijwb
    - NPE in BlazeModuleRendererFactory
    - use flags provider for aspect repository overrides
    - use getProjectFilePath instead of getBasePath in AspectRepositoryProvider
    LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    9404381 View commit details
    Browse the repository at this point in the history
  11. Proactively warm-up the VFS before indexing

    1. Detect when scanning/indexing may start by implementing a "no-op"
       `IndexableSetContributor`
    
    2. Launch background re-scanning of the VFS each time
       `IndexableSetContributor`s are asked to provide current additional
       project roots to index. Walking the VFS caches children nodes of
       each directory and prevents them being loaded on a single scanning
       thread when launching indexing.
    
    3. Retrieve the `fileType` of each processed file to prevent file type
       detection from content happen on a single thread.
    
    4. Re-start any not finished scanning if new roots are requested. They
       or the file system might have changed.
    
    Bug: 295270704
    Test: SyncedInBazelProjectTest (as a smoke test)
    Change-Id: I50d19a5615c659b066281917b1b5608584c14624
    
    AOSP: 96405fbb3862a1f666125d53d71489d18947507d
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    f51705d View commit details
    Browse the repository at this point in the history
  12. Make FileSystemWarmUpService less nested

    Bug: 360816302
    Test: n/a (checked that all processing runs at the same job nesting level)
    Change-Id: I579820d44bab3eb02c934669bc7c2c42466fd7d5
    
    AOSP: 3d8205da50f77add01f6fd9051b3ae6b9a8c1aa8
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    04bfcbd View commit details
    Browse the repository at this point in the history
  13. Inline QuerySummary proto interning

    and replace it with simple string interning in place. It may save up to
    a few minutes of runtime on 11gb of query results.
    
    Bug: 359618797
    Test: n/a
    Change-Id: I31092fd71e3671f34dd8a75648b4a3f1b27d25af
    
    AOSP: c6494f6a976faf54c7a23377d2c86db3b3683dbb
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    ea8f330 View commit details
    Browse the repository at this point in the history
  14. Move ASwB tests to tools/adt/idea/aswb

    Change-Id: Ib7693c073e77ce053f3b8a652f99b2d0098cc16d
    Bug: 349186243
    Test: presubmit tests
    
    AOSP: caa9291e4c4113815532f8ccc4e9d6aecfb29496
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    b8e272b View commit details
    Browse the repository at this point in the history
  15. Do not use com.intellij.history.core.Paths

    This class comes from a plugin and might not be available at runtime.
    
    (and auto-remove some dead code)
    
    Bug: 360937664
    Test: n/a (BlazePackageTest showing the new impl works)
    Change-Id: I3b4d283f95e135a56256046e182a590993f0dbf2
    
    AOSP: c106a091a63d41fb0eb71eb24b9d114a38180077
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    d2eacd3 View commit details
    Browse the repository at this point in the history
  16. Allow implementing com.intellij.openapi.startup.ProjectActivity

    in Java. Although it is not very efficient.
    
    Bug: 361342128
    Test: n/a
    Change-Id: I93023d9d58a4953b2944352988fd103b6b25f5c8
    
    AOSP: 2314f67b3cdaf23b556e0fb8b3bf4facc45d10f2
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    dba3ecb View commit details
    Browse the repository at this point in the history
  17. Move ASwB test data to tools/adt/idea/aswb

    Change-Id: I3c6627a7b70effbe2f7ed8c0e6fca70406bbe248
    Bug: 349186243
    Test: presubmit tests
    
    AOSP: 78424e2f9905bac93d5ce24285c4821231097bd9
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    c754e7a View commit details
    Browse the repository at this point in the history
  18. Cleanup unused code and tests

    Bug: NA
    Test: NA
    Change-Id: I79783b4674d5bee550e0480027860234a4d242fd
    
    AOSP: 82489b4af33086a576bdc94037c28e75dc39feae
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    a02409f View commit details
    Browse the repository at this point in the history
  19. Remove unused futures from EditorDesignSurface refresh methods

    Bug: 335424569
    Test: N/A
    Change-Id: I013bcc2cf0a2d6d28a4a3a20af1fc035f21b8113
    
    AOSP: 36515f4623247cd7c1332eb321f017739f652d28
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    784887b View commit details
    Browse the repository at this point in the history
  20. WORKAROUND: Fix saving huge project snapshots

    A better fix would be to store data in more compact form.
    
    Bug: 362727747
    Test: n/a
    Change-Id: Ibbb479b1cad715451c9b60f050f4e2fc9a50e667
    
    AOSP: 2dd8f7869efa9658eedb760e8cfbd8b925683296
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    44698be View commit details
    Browse the repository at this point in the history
  21. WORKAROUND: create temp workaround for build cache artifact missing e…

    …xception.
    
    The final step of sync/ build process is to convert Project proto to
    new snapshot. And we will create modules and libraries (project
    structure) according to this snapshot. Currently, we always create the
    snapshot from build graph without incremental update. So if build cache get
    prune but build graph is not, convert project proto to snapshot would
    fail to access those expired artifacts which are still listed in build graph but have been removed from build
    cache. However, they should have been copied to local directory during
    last build. So we should be able to access them from those directories. In
    such directories, they have *.contents file which stores all paths under
    the directories to its artifact digest. It can help us to trace from digest to the exact file.
    
    Test: added
    Bug: b/357876275
    Change-Id: I98d6f5bb4133becb4f648eb20128a4c25f2615f2
    
    AOSP: 7b9f2af61e21cede77b4fb2da05aab4bb2885b11
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    92f0796 View commit details
    Browse the repository at this point in the history
  22. Rename getRelativePath -> getBazelOutRelativePath

    to avoid any doubt when consuming.
    
    Bug: n/a
    Test: n/a
    Change-Id: Iec5b881ee5e1fbf789ce1272f656de56e3f33973
    
    AOSP: d80b5858722cca524960811e78e5af9e3f1abc1d
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    08b56d5 View commit details
    Browse the repository at this point in the history
  23. Remove translateOutputArtifacts methods

    as they are no longer needed after CL 551232067, which introduces
    `SrcfsOutputArtifactParser` and handles these artifacts at artifact
    parsing time.
    
    Bug: n/a
    Test: n/a
    Change-Id: I02b8d2d1aee30ad30df3f56e3730e266550b9f31
    
    AOSP: 1be8be32b7a9d17c71ed49c766be8eed1f62b711
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    a537fa8 View commit details
    Browse the repository at this point in the history
  24. Store string indexes in rules

    to reduce the proto size and avoid exceeding 2gb on some large projects.
    
    Savings are around: recently became >2gb => 828mb.
    
    Bug: 362727747
    Test: QuerySummaryTest
    Test: manually tested with the project that previously failed to sync
    Change-Id: I8f400428d18aa01fcded28cb6c2dca13975f29f2
    
    AOSP: 1bab134457b1ad37fe2d4dbbe52eecd13bc5b54d
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    3fa48ca View commit details
    Browse the repository at this point in the history
  25. Prefer ApplicationProjectContext to ApplicationIdProvider

    Note: Implementations of `ApplicationProjectContext` that are passed to
    run configuration executors are initialized from the same instances of
    `ApplicationIdProvider` that were passed to the executors and, thus,
    this change is not supposed to change any behavior.
    
    Delete `AndroidRunConfigurationExecutorTest.runGetApplicationIdException`
    test since unlike `ApplicationIdProvider.packageName`
    `ApplicationProjectContext.applicationId` does not throw.
    
    Bug: 339638009
    Test: n/a
    Change-Id: I73521a715f6a4e52243ba83f9d7735123744bcc4
    
    AOSP: 82063e4380e9fda66204f8db658c64a0410a6eeb
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    0267b21 View commit details
    Browse the repository at this point in the history
  26. Noop implementation of BuildSystemFilePreviewServices for Bazel

    Adding a noop implementation to unblock design tools and fix the error
    thrown when opening the layout editor. There is a separete UI rendering
    NPE issue unrelated to BuildSystemFilePreviewServices (b/364920033).
    
    Bug: 357932689
    Bug: 355782163
    Bug: 364920033
    Test: NA
    Change-Id: I9f646436fde21daa794dc2f5dc9b63d2bcb53cb5
    
    AOSP: 8cca96f3feeccb769ff46c7020059ed98c3c7aa6
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    5d75b38 View commit details
    Browse the repository at this point in the history
  27. Rename project system filenames from Blaze... to Bazel...

    Bug: NA
    Test: Existing tests updated
    Change-Id: Id942c3be9cb65bd28326e9e04cf6cdfe3974bfec
    
    AOSP: 8f09f18928e306264aff10dc1859f5fc9bdd9a6a
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    219a51f View commit details
    Browse the repository at this point in the history
  28. Update testdata to use out own code as "external" deps.

    Rather than using guava. This makes the test data fully under our control.
    
    Test: indeed
    Bug N/A
    
    Change-Id: I60709454aa4c85d305ea22d12b8787c7847439f5
    
    AOSP: e460f4d2ed682ce0d70a6c5442e53ef2cea1f924
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    467b2f6 View commit details
    Browse the repository at this point in the history
  29. Make test data more realistic

    in some deployment related tests.
    
    Bug: 365530615
    Test: n/a
    Change-Id: I3af4861068752e5127dce5e1435546c099694639
    
    AOSP: 02167ba65d2a02a2b65dcae3fdababbacb91dcab
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    60effa1 View commit details
    Browse the repository at this point in the history
  30. g3plugins depend on com.android.tools.design

    as ASwB provides implementations to various extension points that rely
    on classes from `com.android.tools.design`.
    
    Declare this dependency explicitly to prevent `ClassNotFoundException`s.
    
    Bug: 364920033
    Bug: 365093286
    Test: manually verified
    Change-Id: If812635cc74c2e0415bc0fb374d46d123cbf3dda
    
    AOSP: 14c48e5ce89f1d6314ff9829b605d591b63dbd29
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    6046d17 View commit details
    Browse the repository at this point in the history
  31. Refactor usage and delete RenderResultCompat

    Compat code is no longer required for ASwB as only a single version is
    released from repo, and separate braches would be used for the other
    versions (viz. canary from studio-main, beta from studio-<beta name>
    etc), Future CLs would remove sdkcompat code from repo and move
    BlazeRenderErrorContributor from sdkcompat/ to src/ folder.
    
    Test: NA
    Bug: 365095575
    Change-Id: I3d122a7a3c9083dbdf44a7cb63d0fc4bd44804eb
    
    AOSP: 19d29071db190bcb66427a334f3447e163fb0d56
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    bbd75ca View commit details
    Browse the repository at this point in the history
  32. Reinstate some C/C++ functionality.

    This was accidentally omitted (never finished) during the new artifact
    tracker implementation work. Wire `ProjectProtoTransform` into the
    project loader, and update the related classes to use the new data
    structures produced by the new artifact tracker.
    
    Bug: 323346056
    Test: Manual; tests blocked by b/338177779
    Change-Id: I5c0afa0dcc8580b4e0060e8f9cee490e739db4c0
    
    AOSP: 1601e6813a829e3f628c2ddffb3a5d3d99e44ad0
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    8ed00ad View commit details
    Browse the repository at this point in the history
  33. Update query sync promo.

    When query sync is already enabled, change the text to say that the
    project needs to be re-created, both in the promo and in the settings
    screen.
    
    Also refactor the enabled logic to avoid duplication.
    
    http://screen/42DcqHEVfsAZx9p
    http://screen/7MRYRLqUAbNoeNV
    
    Bug: 356673637
    Test: Verified manually using `ShowPromoAction`.
    Change-Id: Ib736321227f986f85e9c2173a7def123443de3c1
    
    AOSP: b108f0fb446f246b75bf9555c4f4825ecc2c32c9
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    44a1605 View commit details
    Browse the repository at this point in the history
  34. Refactor usage and delete RenderLoggerCompat

    Compat code is no longer required for ASwB released from repo. So
    refactor and remove usage.
    
    Test: NA
    Bug: 365095575
    Change-Id: Ia4850e23447d102ccf82591ece46d0be6a0a3b06
    
    AOSP: 1dfe1bfbe47e788dbfe0b1b5318eba3d10db482d
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    f3c4b7b View commit details
    Browse the repository at this point in the history
  35. Delete RenderErrorContributorCompat

    RenderErrorContributorCompat is no longer used and compat code is not
    required for ASwB in repo.
    
    Test: NA
    Bug: 365095575
    Change-Id: Ib36b64c96c8438be282f9399e4ff7f96f263b7c7
    
    AOSP: 6ee8fec3e47ad9e1dd318f4f9f858bdb8e81f2ca
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    662dab2 View commit details
    Browse the repository at this point in the history
  36. Refactor usage and delete RenderServiceCompat

    Compat code is no longer required for ASwB released from repo.
    
    Test: NA
    Bug: 365095575
    Change-Id: I3aa25a7f800afb08ca747badc9abe17179ae90a4
    
    AOSP: 2bb109047e7514ca8b28b97d57cb3484583b438e
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    798a41f View commit details
    Browse the repository at this point in the history
  37. Refactor usage and delete HtmlLinkManagerCompat

    Test: NA
    Bug: 365095575
    Change-Id: Ib771186a8d7e76b6b314ae41d24fcc6b0566b1e5
    
    AOSP: 15925d95666ea634256f69b7fc1935a8a7b16096
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    8f51853 View commit details
    Browse the repository at this point in the history
  38. Fix NoneType error when building deps.

    Use the `_aidl_lib` attribute from the rule when present since
    `AndroidSdkInfo.aidl_lib.files` is no longer populated (in Blaze).
    
    Leave the old codepath in place for Bazel and for backwards
    compatibility in future.
    
    Bug: 364971636
    Test: google3$ blaze build
      --aspects=//.aswb:build_dependencies.bzl%collect_dependencies,//.aswb:build_dependencies.bzl%package_dependencies
      --aspects_parameters='include=//third_party/java_src/android_libs/rcsengine'
      --aspects_parameters='exclude='
      --aspects_parameters='always_build_rules=java_proto_library,java_lite_proto_library,java_mutable_proto_library,kt_proto_library_helper,_java_grpc_library,_java_lite_grpc_library,kt_grpc_library_helper,java_stubby_library,kt_stubby_library_helper,aar_import,java_import'
      --aspects_parameters='generate_aidl_classes=True'
      --aspects_parameters='use_generated_srcjars=False' //third_party/java_src/android_libs/rcsengine/csclientlib/java:csclientlib
      //third_party/java_src/android_libs/rcsengine/csclientlib/java:version_debug
      //third_party/java_src/android_libs/rcsengine/csclientlib/java:csclientlib_debug
      //third_party/java_src/android_libs/rcsengine/csclientlib/java:csclientlib_release
      //third_party/java_src/android_libs/rcsengine/csclientlib/java:lint_test
      //third_party/java_src/android_libs/rcsengine/csclientlib/java:version_release
    Change-Id: I3e33f1ec2397ad6c74392dde027b4d610d863ec0
    
    AOSP: 55cfa655be0b6f57d8fe4c69e52369a7f0cff328
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    944c6df View commit details
    Browse the repository at this point in the history
  39. Refactor usage and delete StudioLoggerProgressIndicatorCompat

    Test: NA
    Bug: 365095575
    Change-Id: I57fced0341f5eee2fb6d3ffcbb2adb4bf82b38f2
    
    AOSP: a58f1f7418437dd3729f36966951661f203053d6
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    7dda44a View commit details
    Browse the repository at this point in the history
  40. Refactor usage and delete AndroidManifestIndexCompat

    Test: NA
    Bug: 365095575
    Change-Id: Ia339ea9f2d79711240eee7d75844c6eb2dbcb9aa
    
    AOSP: 87661c3a686a79d3be5479d58fd09b35ada74c71
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    4d9d3d1 View commit details
    Browse the repository at this point in the history
  41. Rename & Move DeployTasksCompat and refactor usage

    Test: NA
    Bug: 365095575
    Change-Id: Ibcb1d949a67abc5856fd37acf1a7533ffcf85832
    
    AOSP: 49f1417f9c11b4579287709dc5eddf8d468d4271
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    d5f33fc View commit details
    Browse the repository at this point in the history
  42. Refactor usage and delete BlazeAndroidBinaryNormalBuildRunContextCompat

    Test: NA
    Bug: 365095575
    Change-Id: I6aef14f7e95863355408eeb7ddc1f96ec7cd7693
    
    AOSP: 1f70eda5d83889e02aac5eb64e149ad035312ae8
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    12577b0 View commit details
    Browse the repository at this point in the history
  43. Refactor usage and delete BlazeAndroidBinaryMobileInstallRunContextCo…

    …mpat
    
    Test: NA
    Bug: 365095575
    Change-Id: I31b69b386019cee6a2cc0aabb1015215c05ae0ba
    
    AOSP: 89f21f6dfc0769419d58bcc6c8ce5a74fa156036
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    7baf8a2 View commit details
    Browse the repository at this point in the history
  44. Rename BlazeAndroidBinaryRunConfigurationHandlerCompat to BlazeAndroi…

    …dBinaryRunConfigurationHandlerTestHelper
    
    Rename BlazeAndroidBinaryRunConfigurationHandlerCompat to
    BlazeAndroidBinaryRunConfigurationHandlerTestHelper as there is no
    compat class in repo. Class overrides a method for testing purpose so
    rename the file as TestHelper.
    
    Test: NA
    Bug: 365095575
    Change-Id: I77eb29e02c911b75d1845415a033af463b92d6b7
    
    AOSP: c951c0c4a9eee40265735c676b4a3503ba1fb754
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    80eef2c View commit details
    Browse the repository at this point in the history
  45. Delete LaunchOptionsCompat as it is not used

    Test: NA
    Bug: 365095575
    Change-Id: I4620b218433f82b91503623af981c06d59f0dd5e
    
    AOSP: 173997ad2019d1f7fc08c12d54fc49e5d2bddead
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    ddff162 View commit details
    Browse the repository at this point in the history
  46. Delete sdkcompat folders for as231, as232 and asdev

    Delete sdkcompat folders for older versions of IDE (as231, as232 and
    asdev) as they are no longer used in repo.
    
    Test: NA
    Bug: 365095575
    Change-Id: I3c9a37e2bd3580e3dcbce8e6fd16962d08d222d7
    
    AOSP: 1750b5a8694b32f024b64446b2a4cc9f527124e0
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    f767319 View commit details
    Browse the repository at this point in the history
  47. Rename GoogleMavenArtifactIdCompat to GoogleMavenArtifactIdHelper and…

    … refactor usage
    
    Also fix the typo in getLabelForGoogleMavenArtifactId method.
    
    Test: NA
    Bug: 365095575
    Change-Id: I022ebc6972615c6822a108bca39def3f0f985d74
    
    AOSP: e044b691c0c7f86104f131013aa5cb78f9c77d63
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    05dda99 View commit details
    Browse the repository at this point in the history
  48. Refactor usage and delete IdeSdksCompat

    Compat code is no longer required in ASwB, so refactor usage and delete
    it.
    
    Test: NA
    Bug: 365095575
    Change-Id: I8f7f9435c2a3fb7fd7d7d80b40c57d5e390f2cdb
    
    AOSP: e76ca43d11e2404a95289454996d130cc004a965
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    53bb99e View commit details
    Browse the repository at this point in the history
  49. Refactor usage and delete AndroidDeviceCompat

    Test: NA
    Bug: 365095575
    Change-Id: I97b57dd33ce589ead7412c5633c1f3bd0fe37fa3
    
    AOSP: dfd23fdab79918058440e59c825071aaaecc68e0
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    87b34db View commit details
    Browse the repository at this point in the history
  50. Refactor usage and delete AndroidDebuggerCompat

    Test: NA
    Bug: 365095575
    Change-Id: I070612a15bd2167336d029d47d7d42e0fa266535
    
    AOSP: d8b9b2f9375da0bda45383acb91555c8a84edbf6
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    6df5896 View commit details
    Browse the repository at this point in the history
  51. Delete sdkcompat in tests and move its files

    Test: NA
    Bug: 365095575
    Change-Id: I957325d2a26e44c457ed83c0c4256ddf89375131
    
    AOSP: 1e72e4a9932d5ec0ecb103dc07ee75e3eda6ce80
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    813a398 View commit details
    Browse the repository at this point in the history
  52. Refactor usage and delete ConfigurationCompat

    Test: NA
    Bug: 365095575
    Change-Id: I63026a6a1eb9754301e366c6c4c90a34312147f5
    
    AOSP: 1958c390fe994e3c0cda93c20a5dd7e92940dba9
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    633990f View commit details
    Browse the repository at this point in the history
  53. Move files from sdkcompat to src

    Test: NA
    Bug: 365095575
    Change-Id: Ic3d6e8f5ef6f192f114c228aca67f8c81868866d
    
    AOSP: 51986036389adb93adc61deb56b1c7f7405dd366
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    121abe6 View commit details
    Browse the repository at this point in the history
  54. Remove sdkcompat from integrationtests

    sdkcompat folder does not exist for integrationtests so remove entry
    from BUILD file.
    
    Test: NA
    Bug: 365095575
    Change-Id: Ia1b873bc3b3e01f9cc0cff5b6d3b1e77743cd5b1
    
    AOSP: c0ee4c754d28cd246d4c40c498176266c6766f81
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    9833eb5 View commit details
    Browse the repository at this point in the history
  55. Move files from unittests/sdkcompat to unittests

    Test: NA
    Bug: 365095575
    Change-Id: I7333848e42e218670de8bf12453628dae94a50f2
    
    AOSP: 9f2bdfc2c793f77a8bd313ec3773880379333c04
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    8896c1b View commit details
    Browse the repository at this point in the history
  56. Remove unnecessary dep on plugin_api

    ... to make it easier to copybara and maintain in Google3.
    I tried unsuccessfully to find where this came from. Looks
    like it can be safely removed.
    
    Bug: n/a
    Test: bazel build //tools/adt/idea/aswb/querysync/java/com/google/idea/blaze/qsync/project
    Change-Id: I27d57750358cf6d50b415e50317f86cf79950442
    
    AOSP: 849587dab42bd823d0d7a6c1bca87e80f1bbd29d
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    f271c6e View commit details
    Browse the repository at this point in the history
  57. Use artifactPath in OutputArtifactInfo

    instead of `bazel-out` relative artifact path.
    
    This is to simplify handling of runtime jars for compose previews.
    
    Bazel uses artifact paths that include `bazel-out` and these are the
    paths returned by `File.path` property in Bazel. However, for historical
    reasons ASwB removes this prefix and it for consistency it must be done
    in multiple places. However, not all files under a Bazel execution root
    have `bazel-out` prefix. Files linked to source files do not and such
    paths are left intact, which make it difficult to use `bazel-out`
    relative paths to access files which might both come from the source
    tree and being produced by rules.
    
    1. Add `artifactProperty` to `OutputArtifactInfo`, which holds the same
       path as Bazel's `File.path` returns;
    
    2. Implement the old `bazelOutRelativePath` property as a function
       that trims the prefix onm the fly. (A little less efficient than the
       current implementation but it will get better with upcoming changes)
    
    3. Implement backward compatible serialization of `OutputArtifactInfo`
       implementations. Assumptions: (1) no `isSource` files are stored this
       way and (2) the missing prefix can be recovered from a
       `BuildSystemName` value.
    
    4. Stop supporting legacy bazel versions (pre 2019) that did not have
       `path_prefix` field in the build event protocol's `File` message.
       A workaround handling this corrupts the artifact path for files
       coming from the source tree and it is no longer needed.
    
    Upcoming changes:
    - migrate usages to `artifactPath` where it makes sense
    - stop removing the prefix in `build_dependencies.bzl` and match its
      outputs with `artifactPath`
    - derive mnemonic property value from the path
    
    Bug: 331381702
    Test: n/a
    Change-Id: I15b5fe4c2cf0d41800abb36b522cbbc287106031
    
    AOSP: 211903992d0bff4d5236a7ad341be3b5fe795b38
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    189a9be View commit details
    Browse the repository at this point in the history
  58. Ensure all jars are attributed to the right target.

    In the aspect, instead of assuming that all jars provided by
    `JavaInfo.compile_jars` and `JavaInfo.transitive_compile_time_jars` come
    from the current target, use the `file.owner` API to attribute them to
    the target that actually produced them.
    
    To achieve this, we don't add these file to the `target_to_artifacts`
    map as we encouter them, but add them after we've collect all
    dependencies instead, using the depset of all jars that we build anyway.
    
    This ensures that the downstream IDE code correctly attributes all jar
    files to the actual target that built them, which in turns allows the
    jar to source resolution implemented inside `ArtifactIndex` to work
    properly. That is used by `QuerySyncNavigationPolicy`, so fixing it
    ensures "go to definition" actions works reliably for external
    dependencies.
    
    To test this change, we also add support for unit testing of the aspect
    code.
    
    Add support creating rules to create a `.java-info.txt` file to
    simulate build deps for a set of targets, with a custom project scope
    (i.e. set of include directories). Add support to build_dependencies.bzl
    for this, as required to work around the restrictions that bazel places
    on aspect parameters when the aspect is invoked from a build rule.
    
    Also add a unit test to assert some things about the aspect output that
    we want to be true:
    - each jar file is listed under a single target
    - a target than exports other targets should not contain those exported
      jars
    
    Bug: 353651427
    Test: Unit test included, manually verified.
    Change-Id: I2caea196373a9d9fed47164c0f9ef97cfc885cb9
    
    AOSP: bcfadb67403db980511bea766f1c8477c0aa1844
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    70f3093 View commit details
    Browse the repository at this point in the history
  59. Move bazel-version specific import etc into a separate file.

    Intsead of needing to re-write the aspect file at runtime to support
    other versions/variants of bazel, move version specific imports to a
    separate file that can be replaced entirely.
    
    Update the code in `BazelDependencyBuilder` to support populating the
    workspace with multiple files to enable this.
    
    Bug: 364971636
    Test: Treehugger should cover this.
    Change-Id: I910687a9ed2e142da7ed34350896d1fbee623fa9
    
    AOSP: 4259fe4964d94a433bd7bda24ee8e8a8c536e69f
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    d86f351 View commit details
    Browse the repository at this point in the history
  60. Do not use outRelativePath in query sync (almost)

    1. Make `build_dependencies.bzl` aspect return full artifact paths
    2. Use full artifact paths in query sync (including to persist its
       state)
    3. Update prebuilt project test infrastructure
    4. Leave legacy sync and deployment intact for now.
    
    Bug: 331381702
    Test: n/a
    Change-Id: I626e4983b7ec43870343cf4dd06e4d6d47351a55
    
    AOSP: b4a02554c39c29c5ca777d46143ee59335b4ad8d
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    71756c9 View commit details
    Browse the repository at this point in the history
  61. Use new AndroidIdeInfo API when available.

    Use it in preference to android_common.AndroidIdeInfo, but fall back to
    that if the new API is not present.
    
    Bug: 364971636
    Test: Manual; tests blocked by b/338177779
    Change-Id: Ib05a26a945a4f29d0a82f3c6a6c25186f46f598b
    
    AOSP: a7c1aa63d214699fcb9061e235060fd672570e43
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    80b8002 View commit details
    Browse the repository at this point in the history
  62. Avoid using com.intellij.history.core.Paths

    This avoids the need to depend on platform module
    intellij.platform.lvcs.impl.
    
    Bug: 349849955
    Test: DeprecatedLoadQuickFixTest
    Change-Id: I442f36dcb1c721ac048096dfac6c61d6d751b213
    
    AOSP: 6fdf79cb922f07ab4d083d5b8c89a798a000b043
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    dc9bedd View commit details
    Browse the repository at this point in the history
  63. Define a source provider for all variants, all artifacts

    Bug: 147586218
    Test: existing tests adjusted
    Change-Id: I7e9a462c25a682aa2163b17aab6f19ae138bbcb9
    
    AOSP: f3858b9b99fee7079308a5d82c9cff131aea2e65
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    4a3bf0d View commit details
    Browse the repository at this point in the history
  64. assume-verified Support for Deployment

    Fixes: 368135808
    Test: None. Adding UI. Backend test exits.
    Change-Id: I4eed5d96d5b6d33c1ce45993243dcaa8e97c7d5f
    
    AOSP: 4c92354fd597aa7ef4844d3e5e690a1b70539290
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    a23fa06 View commit details
    Browse the repository at this point in the history
  65. Get module for file within read action

    `getModuleForFile` is an IJ internal method and invoking it via read action internally accesses data using a read lock. Its not possible to read the data without a read/write lock and will throw the exception in the bug.
    
    Fixes: 367277234
    Test: Manually tested
    Change-Id: Ibddecb430699084dbd84f183d4ce5ac38352a082
    
    AOSP: 5dae7e27ae1ff41501ff7ffe862119bdabaf8ef1
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    013c529 View commit details
    Browse the repository at this point in the history
  66. Add derived artifact metadata to artifact tracker state.

    This will be used to extract and store artifact metadata at
    dependencies build time. This will address problems with the
    project proto updaters and build cache retention, by avoiding
    the need for project proto updaters to access build artifacts
    directly.
    
    Bug: 357876275
    Test: Unit test included.
    Change-Id: I783953684df05cb60b247823157033d6dac770a5
    
    AOSP: 30f521605822a9120678e4316e5978a34c5ae3e1
    
    # Conflicts:
    #	querysync/java/com/google/idea/blaze/qsync/deps/BUILD
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    6767024 View commit details
    Browse the repository at this point in the history
  67. Add interfaces to support artifact metadata.

    ArtifactMetadata represents a type of metadata that can be extracted
    from a build artifact. ArtifactMetadataProvider allows the artifact
    tracker to query which metadata is needed per build artifact.
    
    ProjectProtoTransform implements ArtifactMetadataProvider to allow a
    transform to specify which metadata is needed.
    
    While we're here, also move ProjectProtoTransform into the top level
    package to reflect the fact that it's scope is now wider than just the
    project package.
    
    Follow-up CLs will add logic to the artifact tracker to extract and
    store this metadata, which will then allow project proto transforms
    to request is later on.
    
    Bug: 357876275
    Test: No functional changes in this CL so no new tests yet.
    Change-Id: I7a483ee91f8312bfc7a2cff606f395524f4eea71
    
    AOSP: 84e61bb7efe3d82c9920889f03f50015369b1310
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    d7959ae View commit details
    Browse the repository at this point in the history
  68. Move combine_visibilities from `tools/vendor/google/aswb/third_part…

    …y/java/jetbrains/build_defs.bzl` to `tools/adt/idea/aswb/build_defs/build_defs.bzl`
    
    Change-Id: I40f67e739c86ba13e5455c32fb3996902de4850d
    Bug: 349186243
    Test: presubmit
    
    AOSP: 7af1ba85bfa2e6821be75cc7e189dfac823d4d23
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    8be380e View commit details
    Browse the repository at this point in the history
  69. Move tools/vendor/google/aswb/third_party/java/auto to `tools/adt/i…

    …dea/aswb/third_party/java/auto_value`
    
    to enable building AS with Bazel from AOSP
    
    Change-Id: I0f1a425c48eab8e197fdd8443943fff90f27d42e
    Test: presubmit
    Bug: 349186243
    
    AOSP: 021fa52b4e3d2b3af17e4fb6e93a506d61ed4385
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    406f220 View commit details
    Browse the repository at this point in the history
  70. Extract and store artifact metadata when downloading new artifacts.

    In the artifact tracker, extract all required metadata from downloaded
    artifacts. Store this metadata inside the artifact tracker state, to
    allow it to be extracted later on when needed.
    
    Bug: 357876275
    Test: New unit test included.
    Change-Id: Id5406ebc19df876b8979f5498f0516462ca967c1
    
    AOSP: d7052f0319435df621f31befa958d651834177ba
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    47ee687 View commit details
    Browse the repository at this point in the history
  71. Register the extension BazelApplicationProjectContextProvider

    for the AS with Bazel plugin
    
    Change-Id: I623a77b8354524e0d0154ea2838f2e95ddb16d8c
    Bug: 349186243
    Test: presubmit
    
    AOSP: 8f4770951800c30753b6cb8625a1add039a36158
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    7b00edb View commit details
    Browse the repository at this point in the history
  72. Revert "WORKAROUND: create temp workaround for build cache artifact m…

    …issing"
    
    This reverts commit 7b9f2af61e21cede77b4fb2da05aab4bb2885b11.
    
    Reason for revert:
    Revert in order to implement long term fix.
    
    Bug: 357876275
    Change-Id: Ie47f06c4178a30de3f74c2e45faf6564afc16c94
    
    AOSP: 7b4aa0433640e5d39141f86a3121f6abcf467672
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    edff0ba View commit details
    Browse the repository at this point in the history
  73. Use a Function instead of a custom interface.

    Instead of the awkwardly named ArtifactMetadataProvider, just use a
    function to provide the same functionality to the artifact tracker.
    
    Test: Refactor only, treehugger suffices.
    Bug: 357876275
    Change-Id: I7342bb9f3afb04d2e196d3f086dbb422e5c13705
    
    AOSP: f5b35dce9050c31404e211e47c60362c66c4c4c3
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    85a7948 View commit details
    Browse the repository at this point in the history
  74. Pass artifact state into project proto transforms.

    Most implementations need it, and passing it in explicitly makes the
    contract clearer, and also closer to the functional semantics that we
    want for it.
    
    Bug: 357876275
    Test: Unit tests updated.
    Change-Id: I7b533c5d73a88be05391024ccd5b17c102898a03
    
    AOSP: 5597ed20d302d2af3bdea0fb7acbebd7ba7c0aea
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    75cc0db View commit details
    Browse the repository at this point in the history
  75. Migrate AddProjectGenSrcJars to artifact metadata.

    Instead of reading the inner jar paths when updating the project proto
    (which is unsafe), use artifact metadata to do this. The metadata is
    extracted when artifacts are downloaded, and then can be used later
    when updating the project proto.
    
    Test: unit tests updated.
    Bug: 357876275
    Change-Id: I64683d8674248f38c178b8d4c10b23857f6db479
    
    AOSP: e10a072e8183210fff6f719269a9fbb479ff6108
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    734bf07 View commit details
    Browse the repository at this point in the history
  76. Migrate AddProjectGenSrcs to artifact metadata.

    Instead of reading the package name  when updating the project proto
    (which is unsafe), use artifact metadata to do this. The metadata is
    extracted when artifacts are downloaded, and then can be used later
    when updating the project proto.
    
    Test: unit tests updated.
    Bug: 357876275
    Change-Id: I3cf6b5fd5053260be851ade9a3adca9766d27de2
    
    AOSP: 13119e8b66b15a1342253b7e6bbe5c5acab047e5
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    bd2c735 View commit details
    Browse the repository at this point in the history
  77. Migrate AddDependencyGenSrcsJars to artifact metadata.

    Add an appropriate new metadata implementation. Update
    DependenciesProjectProtoUpdater to remove BuildArtifactCache which is now
    no longer needed there.
    
    Test: unit tests updated.
    Bug: 357876275
    Change-Id: I16516b2ecbb59cbb895c4b98130f573b7bacb9ee
    
    AOSP: 16d3115bc777f9ddeb32f7270f643455297683f7
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    b0741ee View commit details
    Browse the repository at this point in the history
  78. Migrate AddDependencyAars to artifact metadata.

    Create a new metadata type to enable this. Tidy up BuildArtifact
    to remove now unused blockingGetFrom code.
    
    Test: unit tests updated.
    Bug: 357876275
    Change-Id: I19cc7a987ebcf2aef4a36f5e5e15baae30405571
    
    AOSP: 5c518fa1757598525f3421487e46665c9df3bcd4
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    40b34ff View commit details
    Browse the repository at this point in the history
  79. Tidy up ProjectProtoTransformProvider.

    Since it's not safe for implementations of ProjectProtoTransform to
    use many parts of QuerySyncProject, remove it from the factory method.
    Replace it with ProjectDefinition which is safe to use here, and is
    needed by real implementions.
    
    Update AndroidProjectProtoTransform accordingly.
    
    Bug: 357876275
    Test: no functional changes in this CL.
    Change-Id: I5015d976fa735b48b6ea64078f57babeee4d1f73
    
    AOSP: b1fe2e07d2847b8d5b9b6072828a686763196cf3
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    b679222 View commit details
    Browse the repository at this point in the history
  80. Refactor usage of sdkcompat folder and delete it

    These changes have to be done together, else Buildifier complains about missing BUILD files in the stack of the
    changes (gpaste/6091119386689536).
    
    Test: NA
    Bug: 365095575
    Change-Id: Iba65afca5d19a9f4cf15883e28a6c313aa5b3a14
    
    AOSP: 48458504e1f3c0bd3d3a10c9f8da3cc5607bcddb
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    bf5001c View commit details
    Browse the repository at this point in the history
  81. Refactor usage and delete testing/testcompat folder

    Test: NA
    Bug: 365095575
    Change-Id: I0229e76e8a9ff80d8d04f5e9d98d7d1ae67a9dc6
    
    AOSP: 958a6bda20a27abcd7ebd218fd52fce2fc5a6bee
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    0c67b7c View commit details
    Browse the repository at this point in the history
  82. Check if file exists before fetching its children to avoid exception

    Test: NA
    Fixes: 370764786
    Change-Id: Ia81d05e579505960a65ab88fef5e47164ef7c916
    
    AOSP: 35f46f4bc524961a6f72262c6618c3a072bd492e
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    eb53756 View commit details
    Browse the repository at this point in the history
  83. Move actions to Background thread

    Move action update thread to Background thread/BGT to avoid error like
    gpaste/6555332669341696 in log. Similar to ag/28084680.
    
    Bug: NA
    Test: Manually tested some of them
    Change-Id: Icccffa38b9314f8e275aaa0f849bda302795e64c
    
    AOSP: 94f8bf741014863b4af3247e007185530441f891
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    9d809f1 View commit details
    Browse the repository at this point in the history
  84. Fixes for query-sync with Bazel projects

    - recognize packages with `BUILD.bazel`
    - support root package and `.projectview`s with `directories: .`
    - recognize `kt_jvm_binary`
    
    Change-Id: I482fb92b9ece65997c93138e652ac793e6b63fec
    Bug: 309706901
    Test: manual and presubmits
    
    AOSP: 4c245e80df91ba178049b1a7751a63955eddbe53
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    9b65a87 View commit details
    Browse the repository at this point in the history
  85. Remove dep of query sync core library on experiments

    This is part of an effort to enable copybara'ing query sync core library
    implementation into Google3 without dependending on plugin_api.
    See https://docs.google.com/document/d/1rvkOazivxph_jEm2CrAiOoE4ka-aXTAHcPSbzS6pBBo/edit?usp=sharing&resourcekey=0-bboDFQMR9p34l2MR6recAg
    
    Bug: N/A
    Test: //tools/adt/idea/aswb/querysync/javatests/com/google/idea/blaze/qsync/...
    Change-Id: Ie3fcc4770587f8532b9b6db65983ad715371a5df
    
    AOSP: 2c373a0631058fb2880362fb260a58b2f52c68aa
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    812f1d7 View commit details
    Browse the repository at this point in the history
  86. Remove unnecessary dep on plugin_api

    This is part of an effort to make the query sync core library
    code more easily copied and maintained in Google3 for testing.
    It's easier if we don't require the plugin_api in Google3.
    
    Bug: N/A
    Test: bazel build //tools/adt/idea/aswb/shared/java/com/google/idea/blaze/common/artifact
    Change-Id: I133f6807a28ae1207c22f289c81618850b6a593b
    
    AOSP: c8c49a9a5165c95d90cd09b6783c2cc62738eb9f
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    6f3f5c1 View commit details
    Browse the repository at this point in the history
  87. Improve artifact metadata handling and storage.

    Store the metadata inside the BuildArtifact class itself. Update the
    proto definitions to reflect this.
    
    We add specific classes for storing each type of metadata, and also to
    convert this to proto. We also have specific interfaces for extracting
    metadata from build artifacts, and a factory for converting a proto back
    to a java class.
    
    The new metadata support is somewhat generic and extensible: the main
    place this falls down is in the proto definition where all types of
    metadata are handled by a single proto message.
    
    Bug: 357876275
    Test: Unit tests updated accordingly.
    
    Change-Id: I88262c057e6260f80cd32f04cd589c9f99911d25
    
    AOSP: 46d1745775b1b007472aa3a23e14dddb0a0eafc9
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    6db3126 View commit details
    Browse the repository at this point in the history
  88. ASwB: remove usages of trove4j

    Bug: 357843093
    Test: existing
    Change-Id: I7132fa2de5948f1134bae7a20c364ec2a20c0a7a
    
    AOSP: 3dcb412e8df1b84179d1058df2f16c39bb6e3538
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    ba13021 View commit details
    Browse the repository at this point in the history
  89. Retrieve kotlin compiler configuration via

    ApplicationLiveEditServices.
    
    Bug: 339638009
    Test: n/a
    Change-Id: I379624869b1d8c950d0901f966cdcb789be31a32
    
    AOSP: 759ff9a0a665fc36ca21e92d973fe4190b0d9333
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    7457809 View commit details
    Browse the repository at this point in the history
  90. Workaround bazel duplicate depset entries issue.

    There are cases when bazel can yield apparently duplicate File entries
    in a depset. This can occur when two different aspects generate the same
    file. This then causes problems with duplicate entries in the targetInfo
    map in the artifact tracker, and two `TargetBuildInfo` entries are not
    considered identical if one has duplicate file entries.
    
    Fix this issue by storing the `BuildArtifact`s in a set rather than a
    list.
    
    Test: Tested manually.
    Test: Automated test blocked by b/338177779
    Bug: 371973613
    
    Change-Id: If7f5bffbb9e6808863b3491a0659e4513c1fd8b9
    
    AOSP: c1930315adc4f9059838a7c2d32ec0ac7f48e7c6
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    0eae82e View commit details
    Browse the repository at this point in the history
  91. Fix implementation to return not null value

    Method should return a NotNull value so fixed it. Followup to comments
    on ag/29600886.
    
    Test: NA
    Bug: 365095575
    Change-Id: Iece10093fd0d1693d726402e6389414a02c14da7
    
    AOSP: a39aed36c5b19258344672918a771f32c74b8e1d
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    3972b3a View commit details
    Browse the repository at this point in the history
  92. Move flogger, truth and junit from `tools/vendor/google/aswb/th…

    …ird_party/java` to `tools/adt/idea/aswb/third_party/java`
    
    Change-Id: I118b7b24842fb2b1bb82ba3edac98c34cf2aff56
    Test: presubmit
    Bug: 370784150
    
    AOSP: 2401655e1e7ea05ab225a886436e4a023e42122e
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    ec349ee View commit details
    Browse the repository at this point in the history
  93. Refactor usage and delete AndroidFacetModuleCustomizer

    Test: NA
    Bug: 365095575
    Change-Id: I3cd3643462201b060b8d83ac967887544f6dd609
    
    AOSP: bb78ce8e198735e8098880ae7a16844f26d26e98
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    7d66dfd View commit details
    Browse the repository at this point in the history
  94. Refactor usage and delete compat files in aswb/src/org/jetbrains/andr…

    …oid/sdk
    
    Test: NA
    Bug: 365095575
    Change-Id: Ie1ec7a8219b831fdc9391f060dd9de457870a282
    
    AOSP: bf72f60ebbb555413db30a7b8ccfb15e2808aef8
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    9518a36 View commit details
    Browse the repository at this point in the history
  95. Move default Android SDK API level to static variable

    Followup to comments on ag/29693551
    
    Bug: NA
    Test: Manual tests
    Change-Id: I1d291ad8d0fbd9dd248898519fa6d6272d825f64
    
    AOSP: 7387ba2734e1166ed62c59855b3d61787ef48662
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    469087c View commit details
    Browse the repository at this point in the history
  96. Fix conflict errors in the artifact tracker.

    This fixes an error that can be caused when building more than one
    project target at a time, where those targets depend on an external
    target whose compile time jars can vary based on the dependency chain.
    See the comment in NewArtifactTracker.getUniqueTargetBuildInfos for a
    fuller explanation.
    
    Test: new unit test cases included
    Test: integration test blocked by b/338177779
    Bug: 371973613
    
    Change-Id: I3b684ecc13cd4797e2e91e239e8ad484cb9a34b8
    
    AOSP: 39a81c4a4061ff8c7910b68844eba3aa88fd5a84
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    1f91ed5 View commit details
    Browse the repository at this point in the history
  97. bypass CMakeUsageHandlerFactory

    Currently, CMakeUsageHandlerFactory.canFindUsages will return true for
    all PsiNamedElement. And it shows up before DefaultUsageHandlerFactory
    and JavaUsageHandlerFactory. As a result, BUILD file and java file find
    usage would use CMakeUsageHandlerFactory which cannot resolve many usage
    correctly.
    
    As we cannot remove this implementation directly, we create a find usage
    factory to load at first and delegate to other factory with ignoring CMakeUsageHandlerFactory. KytheFindUsagesHandlerFactory also need to run the ignore check as it will be used whenever Kythe serivce is available.
    
    We do not check the instance as import the class would make
    KytheFindUsageHandlerFactory depends on intellij.cmake.psi which seems
    to introduce some unnecessary deps to bypass this issue.
    
    Bug: b/359391056, b/370573555
    Test: manually
    Change-Id: Iabbca7a98114fbe598d83c614b1c02be461a9ac0
    
    AOSP: eaba2a13faf2d9941009e860bc2687f16a027a3e
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    3ba35fc View commit details
    Browse the repository at this point in the history
  98. Improve querysync bugreport file adding.

    Using a map of name -> bytesource allows more logic to be pushed down to
    where it belongs, and also simplifies adding more sources in future.
    
    Bug: n/a
    Test: Manual
    Change-Id: Ia8b332d6c1e93723bb48774b9788e59d3fde33d4
    
    AOSP: 0d704b87e5dbbbc34e719aecbdd69d9efcd0db10
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    c7bc4eb View commit details
    Browse the repository at this point in the history
  99. Application inspector is always one target

    Remove the complexity of handling target lists where it never needed.
    
    Bug: n/a
    Test: n/a
    Change-Id: Ica4608612c76e7eaae0bba7d194160a3825c2039
    
    AOSP: 93fa3c49f29ab8dc7c97824e87e6a9bdda76ec3a
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    f3cce98 View commit details
    Browse the repository at this point in the history
  100. Include artifact store and build cache info in bugreports.

    Bug: 372069513
    Test: File a bug from the IDE and inspect attachment.
    Change-Id: If3bd120ab6ba82455531e612c871ac0afb21f142
    
    AOSP: 18e374dc4b328f8e64b1bfba0949e7ec0a00e344
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    66766e6 View commit details
    Browse the repository at this point in the history
  101. Add a check for DBiP env variable

    DBiP can be enabled by running an onboarding script (go/dbip-onboarding) which sets an environment variable. ASwB needs to check that so that it can use an appropriate invoker.
    
    Bug: 372700434
    Test: n/a
    Change-Id: I4bb8772903e2a835f21866243f9b4e35fcc78281
    
    AOSP: bfedef8169cc5ac0dc1b7a01c6e162b81dac6ccf
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    4b62ed0 View commit details
    Browse the repository at this point in the history
  102. Test to reproduce sync failing to find artifact

    with message "not present in the cache"
    
    Bug: 372069513
    Test: n/a
    Change-Id: Ia6b7e9b907391a7c2b3ef1f38b3bb77cf1895712
    
    AOSP: 103b4900bb821081e276ab0f2ec204a4ed53ce27
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    cba36c4 View commit details
    Browse the repository at this point in the history
  103. Fix race in BuildArtifactCacheDirectory

    Ensure `markAsActive()` is invoked before `unmarkAsActive()`.
    
    Bug: 373934392
    Test: n/a (SyncedPrebuiltFailedArtifactFetchingTest doesn't fail)
    Change-Id: I7d3c3f43607d7ff43723631a3bf0385b5e462708
    
    AOSP: fb8ea8ffee880557da947f5d6b989b6dd96de4e0
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    ddd0685 View commit details
    Browse the repository at this point in the history
  104. Implement AppInspectorArtifactTracker

    after the old implementation was removed because of the migration to the
    `BuildArtifactCache`.
    
    Bug: 370498478
    Test: AppInspectorArtifactTrackerImplTest
    Change-Id: I21db196b8e5acac5d64e910600336217bdbea1d4
    
    AOSP: 744df3bcd1491460968efc8d94aa54998eac9600
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    0c07b8f View commit details
    Browse the repository at this point in the history
  105. Do not update state until artifacts are fetched

    as otherwise not existent artifacts remain in the artifact tracker state
    and cause subsequent sync actions to fail.
    
    Bug: 372069513
    Test: SyncedPrebuiltFailedArtifactFetchingTest
    Change-Id: I3739d06e8367f27f064ae18bece318824bb1ea20
    
    AOSP: f001cc8cba854683de6d125416b3481df7af1ec6
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    3566a72 View commit details
    Browse the repository at this point in the history
  106. Do not suggest go links for external users

    Change-Id: If6dcd67c2804a0c6e9eba33652dd72519d20b919
    Bug: 309706901
    Tests: presubmits
    
    AOSP: 62682fcc4673e488bb8f79379449c7543c7ec56c
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    698cbb5 View commit details
    Browse the repository at this point in the history
  107. ASwB: add test runtime dependency on opentest4j

    ...similar to Change I41794f440 in Studio.
    
    This is needed for compatibility with IntelliJ 2024.3, where
    opentest4j is used in a couple new places in the IntelliJ test
    framework.
    
    Test: existing Bazel tests
    Change-Id: If3a139d8cb701759fea263790784b28bbaf31256
    
    AOSP: f0b0cc79040a2b0c969c82bb04aeb8e1906816f1
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    2e0ed67 View commit details
    Browse the repository at this point in the history
  108. Combine BepArtifactData more efficiently

    Bug: n/a
    Test: BuildEventProtocolOutputReaderTest
    Change-Id: I206baa44625d3ee8cd3f1a9bcd1a7d3b847996e9
    
    AOSP: e25ef9c78b6fe52524b926c810b33beccedd1988
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    0efa962 View commit details
    Browse the repository at this point in the history
  109. Track deps with missing artifacts.

    In some cases, it's possible for a build artifact from a dependency to
    be missing (expired from the cache) when its needed. This never happens
    in normal cases, since by the time the artigact expires from the cache
    it will already be present in the artifact store. But there are cases
    where it can happen, for exampe if some configuration is changed such
    that the transform applied to an artifact is different.
    
    Rather than failing the sync in this case, simply track which deps had
    missing artifacts, and use that information when deciding whether or not
    to enable analysis for a source file.
    
    The upshot of this is that if artifact are missing, than analysis for
    the dependant source file should be disabled again. The user can then
    re-enable analysis for the file to get back to a good state.
    
    This also helps ensure consisency in the event of config changes by
    ensuring that artifact in the project store that correspond to the old
    configuration are removed and replaced.
    
    To do this, we have to make a small change to where the project artifact
    store update is initiated from, since the result from that update can
    affect the snapshot itself. Move the update call from ProjectUpdater to
    QuerySyncProject to handle this.
    
    Note that this CL fixes the crashes observed, but does not always result
    in analysis being disabled for affected project sources. This is because
    we use the query deps graph to track external dependencies whcih does
    not include transitive external deps. So if we are missing artifacts for
    a transitive (rather than direct) external dependency, we do now know to
    disable analysis for the file. This can be fixed using information
    already available to the IDE, and will be done in follow-up CLs.
    
    Bug: 372069513
    Test: com.google.idea.blaze.android.google3.qsync.SyncedPrebuiltProjectTest#missing_cache_artifacts
    
    Change-Id: Id73452a6481e129ab50cc1d03c8f695199d25566
    
    AOSP: aa982c800af6f69d7f13dc6f578f66c3e300f901
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    9dea31e View commit details
    Browse the repository at this point in the history
  110. Support for testing missing build artifacts.

    While purging the project store is not something we'd ever normally do,
    it does allow us to test certain corner cases more easily.
    
    Bug: 372069513
    
    Change-Id: Ifdda654daa813d20451e519d64466541313b8eac
    
    AOSP: bc8299705b148f2768dd8a39e0b8ee490fee01c8
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    c291fca View commit details
    Browse the repository at this point in the history
  111. ASwB: remove usage of ActionUpdateThread.OLD_EDT

    ...since OLD_EDT is removed in IntelliJ 2024.3.
    
    Change-Id: I829ef620c47f4d80e057b9d95268a432ea40ac75
    
    AOSP: 6d15c5d225836e3228c4e86e3c81b08b0e799fc0
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    3b0f3f3 View commit details
    Browse the repository at this point in the history
  112. Address reviewer comments (minor cleanup)

    Bug: n/a
    Test: n/a
    Change-Id: I2fa41e44e33eb0373d036078ef8e2207584bf05b
    
    AOSP: b18450c697e56287fb7be165b83f64a8c1b2479b
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    0ec1276 View commit details
    Browse the repository at this point in the history
  113. Fix AffectedPackagesCalculator when directories: . is used

    Bug: 309706901
    Change-Id: I62724c22f8bb4c35bf4cef76c3cd7d1584177f0b
    Tests: presubmits
    
    AOSP: 7629a11cb2cd2c344f465abd1f3fc3cf0049364c
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    14a09e6 View commit details
    Browse the repository at this point in the history
  114. Add logging for number of deleted entries.

    Test: Covered by unit test
    Bug: 364959386
    Change-Id: I6b1a453381589b6b1bc816e00fb001b262756177
    
    AOSP: 6f384175938a9ab8c85b5ecbe15d97029d5f1a5a
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    2e70d30 View commit details
    Browse the repository at this point in the history
  115. Use --consistent_labels=true (https://bazel.build/reference/command…

    …-line-reference#flag--consistent_labels) to get consistent label format to what can be collected from starlark.
    
    Bug: 309706901
    Change-Id: I3ee3dfd3cf408a53a27b3e2a30fcd121a9afcb8f
    Tests: presubmits
    
    AOSP: d2d209c72627569603f3834f062af382a36fe1ac
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    0ee3cd1 View commit details
    Browse the repository at this point in the history
  116. Run sync queries remotely.

    Due to querys sync's usage of readonly workspace snapshots to run
    queries, we end up with a new blaze instance for each query we run. They
    end up consuming a lot of RAM.
    
    Remote queries do not have this problem, and should not be any slower:
    since using the readonly snapshot results in a new (local) blaze instance
    every time, we also pay the startup time cost for those on each query.
    Remote queries can avoid this startup cost since they share a blaze
    instance across multiple snapshots.
    
    This should result in lower RAM consumption and likely faster query
    times with DBiP.
    
    Bug: 356244980
    Test: Manual.
    Change-Id: I3dbbce2ede83a735ef4e1f06f144369e3aed7114
    
    AOSP: 519d8c9ecf5caa7f11de224b6423203fd9ddcc63
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    1119618 View commit details
    Browse the repository at this point in the history
  117. Remove some unused code

    Bug: n/a
    Test: Treehugger suffices.
    Change-Id: If05351468381bb3b00efb3919553ea4b4de61dc7
    
    AOSP: a2878fdcc55358acdd14e1074c3030c97a516610
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    835474d View commit details
    Browse the repository at this point in the history
  118. Use a record for storing rules instead of a proto.

    This result in significant memory savings, because protos store an empty
    proto list object for every empty repeated field. For a large project,
    this resulted in a 28M duplicate such objects, wasting 2GB of RAM for a
    very large project.
    
    Using a record means that all empty fields share the same empty
    ImmutableList object, and probably other optimizations too. For the same
    large project, this cuts the size of the QuerySummary object by 50%, and
    the whole heap size by about a quarter, a 3GB memory saving.
    
    There is more work to do here. For example, there's no need to create or
    store the `StoredRule` protos when parsing the query output, and
    removing these is likely to give more memory savings. But this CL is
    good to submit as is, especially since it gives good memory savings.
    
    Test: Verified manually using heapdumps.
    Bug: 374171123
    Change-Id: I3569b5ee248d3aa3e7333c17b71c537a29a6811a
    
    AOSP: 69830fcd16f3d3b1090fef59d3408af7b346ad8c
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    25dbcc2 View commit details
    Browse the repository at this point in the history
  119. Make BuildTargetReference not hold module reference

    but only a weak reference. This is make it a replacement for weak
    module references used in rendering.
    
    Weak references are used to prevent leak detectors in tests from
    complaining about references to modules held from the layout lib.
    
    In Bazel implementation there no tests for now and thus a direct module
    reference is fine as long as the implementation correctly returns `null`
    when the module is disposed.
    
    Bug: 331381702
    Test: n/a
    Change-Id: Ie1a9c22d78a5c3c2920db78521d72b602c0674ae
    
    AOSP: 3184086e930101a1aab3b9c7d2093595093bd9ed
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    8af1627 View commit details
    Browse the repository at this point in the history
  120. Remove an erroneous @nullable.

    The implementation returns the result of a `get` call on a
    `SetMultimap` which can never be null.
    
    This fixes some warnings in the IDE.
    
    Bug: n/a
    Test: Treehugger suffices.
    Change-Id: I8235202bf4f2d07cd4357eea3a17383c0c0db1be
    
    AOSP: be167de007bc128bdb669bfcc1a0c3735d8c7cbf
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    f8fad03 View commit details
    Browse the repository at this point in the history
  121. Do not validate/normalize labels on load

    since they have been validated and normalized before being serialized.
    
    Bug: 370729642
    Test: n/a
    Change-Id: I4a49ae7ba2021a400d6634cea59eddc3f2e87173
    
    AOSP: cb3f07cd985b75d7c56f8f42796dca709da95e6b
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    93bd877 View commit details
    Browse the repository at this point in the history
  122. Move formatting logic out of QuerySpec

    Bug: n/a
    Test: n/a
    Change-Id: I9d4971d0b1527af78a1bd816998d06d7af2eeec4
    
    AOSP: c888eca8712e2b62da2b19382f1197462c04d1b9
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    482b91c View commit details
    Browse the repository at this point in the history
  123. Re-arrange rule handling in BlazeQueryParser

    to make it possible to extract the list of rule classes that are handled
    by this class. This is needed to produce a query that filters out
    unneeded rules as it the most straightforward query produces too large
    outputs.
    
    Note, in the future we might want to choose which rules to handle based
    on other criteria and in this case we will also need to review how
    the query selects rules to return to the IDE.
    
    Bug: 362727747
    Test: existing
    Change-Id: Ia0bfbe0ac49e9b5e47669f77e1f90fe66e1e177e
    
    AOSP: a4437ac3f12d712e30e874ee0a22ce1ad4c6431a
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    b31d59b View commit details
    Browse the repository at this point in the history
  124. Introduce query strategies to allow experiments

    with different approaches to fetching the initial project data.
    
    Bug: 362727747
    Test: QuerySpecTest
    Test: QuerySummaryTest
    Change-Id: I89e084665e99ac72f841d5b47a2073d6f88675d4
    
    AOSP: b9f725251eae3f475783c3faa9bc7e2d6b594b8b
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    54f9cfe View commit details
    Browse the repository at this point in the history
  125. Experimental filtering query

    1. Introduce `query.sync.experimental.query` experiment and set the
       default to `false`.
    2. Implement a new query strategy that fetches info on targets that
       are either directly supported by query sync or are their dependencies
       within the project view.
    
    Note: The `allpaths` of the query while being intersected with the
          project scope will likely hit targets outside of the project
          scope and potentially make query execution slower. Experiments
          showed however that it gains more from a smaller result sets on
          most projects, still we set the default value to `false` and
          anticipate that we can make it possible not to query dependencies
          at all.
    
    Bug: 362727747
    Test: manual
    Change-Id: I8d6a4df483a18468cf96925fddd91ebcac715768
    
    AOSP: 7546e56e98d8f2000d2fdc2b1c612da7512f3fce
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    5955b2d View commit details
    Browse the repository at this point in the history
  126. Move DynamicAppUtils

    In theory these are no-longer Gradle-specific, so move them to a more
    generic utility directory.
    
    In practice some of the logic is not generally portable to all build
    system project representations, because (for example) it operates at
    the level of modules and has as an implicit assumption that a module
    can be assigned a single "kind" of Android delivery entity (e.g. a
    dynamic feature), as opposed to multiple entities within the same IDE
    Module.  This implicit assumption is currently approximately valid for
    Gradle-based projects, and not for projects based on other build
    systems.
    
    Support for other build systems can be implemented as and when desired
    by adding to the methods in DynamicAppFeatureOnFeatureToken.
    
    Bug: 300434824
    Test: existing
    Change-Id: Ib22cb947214b6b13d2a526a62793449c7333c345
    
    AOSP: 5daffcb04532130d8082c87a5703f3b04076d0b2
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    9917dce View commit details
    Browse the repository at this point in the history
  127. query.sync.skip.finding.build.output experiment

    to find out whether it is safe to remove the workaround to the platform
    issue that caused inefficient merging of indexing/vfs rescan requests
    on huge libraries.
    
    This change should not have any effect unless the rollout experiment is
    configured.
    
    Bug: 278789513
    Test: n/a
    Change-Id: Iaec1616ec6d507db9206768e218c42337819aabf
    
    AOSP: 723286e63c3a3141da38fd3a175272e5ba5f033c
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    64b751b View commit details
    Browse the repository at this point in the history
  128. Revert "[WORKAROUND] bypass CMakeUsageHandlerFactory"

    Revert submission 29783394-findusage
    
    Reason for revert: The official fixing ag/29883290 has been submitted
    
    Reverted changes: /q/submissionid:29783394-findusage
    
    Change-Id: Ibe72af23db5b213fd5c416e6afa8643aa8a85b70
    
    AOSP: f52f31158372b53631da9d5e1f938cd875c5de57
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    b94fbfc View commit details
    Browse the repository at this point in the history
  129. Configuration menu
    Copy the full SHA
    8ff6abe View commit details
    Browse the repository at this point in the history
  130. Configuration menu
    Copy the full SHA
    e2bcfb4 View commit details
    Browse the repository at this point in the history
  131. Fixed CLion build

    LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    c1b87c4 View commit details
    Browse the repository at this point in the history
  132. Configuration menu
    Copy the full SHA
    7c47302 View commit details
    Browse the repository at this point in the history
  133. Configuration menu
    Copy the full SHA
    0a341df View commit details
    Browse the repository at this point in the history
  134. Fix failure tests

    With 243, Alarm asks a CoroutineScope set with Alarm. Otherwise, it will
    try to fetch it via applciation serivce AlarmSharedCoroutineScopeHolder.
    It's a service that register via annotation and set as private. So it's
    hard to mock an application service for it. In this case, set a dummy
    Scope for it.
    
    Bug: N/A
    Test: //tools/adt/idea/aswb/common/experiments:unit_tests
    Change-Id: I9a5b49d94f4ee38d0a16be857032ce347b3347a0
    
    AOSP: b53f93734a0c871f3558f28999a697ccd9eb83c0
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    f63a65a View commit details
    Browse the repository at this point in the history
  135. Prepare for providers from aspects

    Do not rely on `label` property of a target object as in the current
    version of Bazel it is not available if the target represent a
    toolchain.
    
    Bug: 375410284
    Test: existing integration tests
    Change-Id: I2482c59c9a94e237bcb12ac581d512d7e68a59ba
    
    AOSP: 49387b7567e86af608f9ba97a0b4bf3db0a531e3
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    ead8a6d View commit details
    Browse the repository at this point in the history
  136. Extract Kotlin aspect IDE interface

    and prepare for the upcoming change to Kotlin toolchain handling.
    
    Bug: 375410284
    Test: existing integration tests and manually
    Change-Id: I383dea974fddb1452c6619053d0469dd8f75e30b
    
    AOSP: 97350e893ba8bb075108083f54b2b24a2d2d6734
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    98d4334 View commit details
    Browse the repository at this point in the history
  137. Extract CC aspect IDE interface

    and prepare for the upcoming change to CC toolchain handling.
    
    Note: this is incomplete and only includes the interface needed for
          toolchain support.
    
    Bug: 375410284
    Test: existing integration tests and manually
    Change-Id: I8e7bad390f9cce9299606079d6b3e1f367d350fe
    
    AOSP: 9efef39fda9e7b25458176eed1cd3df7c91d3cd0
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    c803d83 View commit details
    Browse the repository at this point in the history
  138. Check if the Cc toolchain target exists before collecting its `Depend…

    …enciesInfo`
    
    Change-Id: If19c15951f9a0319c4ca595454800b8678347963
    Bug: 378119291
    Tests: presubmits
    
    AOSP: f148ca57ac806f29b39ef34cdfb872b087bb52ac
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    8fc4209 View commit details
    Browse the repository at this point in the history
  139. WORKAROUND: Ignore diffs in target deduplication

    Target info for the same target may have different artifact paths
    when fetched from the target in different configurations. This typically
    happens when a target is in a dependency chains
    of Java and Android targets.
    
    The right fix is to distinguish such a targets.
    
    Bug: 376833687
    Test: n/a (we lack Android test projects in bazel)
    Change-Id: I1a0374d38854e53d5cc0e266506001d49df686d8
    
    AOSP: fb3d773728775bb2007edd5a9e532e406a0d4713
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    d7be50d View commit details
    Browse the repository at this point in the history
  140. Do not attempt to fix source to target map

    as it causes later target info conflicts.
    
    This change effectively reverts
    I2caea196373a9d9fed47164c0f9ef97cfc885cb9 although not its tests as they
    are mostly still applicable.
    
    Bug: 376833687
    Bug: 353651427
    Test: n/a (manually tested to fix conflicts)
    Change-Id: Iae8b38628b4a1b400ff212a166f434a797cfe4b8
    
    AOSP: 512e39a6b528f6d4258009b24e90820b199b429b
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    54eee91 View commit details
    Browse the repository at this point in the history
  141. Handle expand_sources without mutability

    `expand_sources` indicates that a target is a source code transformation
    and its output should not be analyzed by the IDE. The `expand_sources`
    is determined by a target configuration and when such a target is
    consumed is directly known to the consumer and does not require a
    context to be supplied from the outside, which makes the result not
    depend on the target and its dependencies exclusively.
    
    Bug: 376833687
    Test: SyncedPrebuiltProjectTest
    Test: SyncedInBazelProjectTest
    Change-Id: Ie8eaf8b3ffb42bce3370afe3df225020120bc6ce
    
    AOSP: e95dd8cc92104c856f71f643e99542c81de9f240
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    6da52b9 View commit details
    Browse the repository at this point in the history
  142. Merge cc and java infos correctly

    without creating empty java or cc infos which later confuse target
    deduplication.
    
    Replace generic merging with explicit merging of specific info types.
    
    Bug: 376833687
    Test: n/a (to be added later when Android test projects available)
    Change-Id: I2425f252eaadce50af2915953a3e695ed02f2632
    
    AOSP: ed316245b0831dd2c6eaec9b9b600f0442a4f8e5
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    e64e77f View commit details
    Browse the repository at this point in the history
  143. Display artifact number and sizes

    when downloading.
    
    Bug: n/a
    Test: n/a
    Change-Id: Ie87317a6c6962341773de142bcde5a86617b204e
    
    AOSP: 262fcfaeb6af81c949bdc5e16a04e012aee71c42
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    5234afa View commit details
    Browse the repository at this point in the history
  144. Add "Reset sync" action

    Bug: n/a
    Test: n/a
    Change-Id: I1d4bf3ca5f13a3a8d48bb3b4d2f65204ca17f0ab
    
    AOSP: a46b766372c62d18763ccbb4caf800a5b2d5f6af
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    6684c7e View commit details
    Browse the repository at this point in the history
  145. Do not run queries in snapshot directories

    Add `query.sync.run.query.in.workspace` experiment (default `true`) to
    disable running queries in a snapshot directory.
    
    This may result in query results reflecting a newer state of the
    workspace or even failing because of inconsistencies caused by the user
    editing files.
    
    In general this is not expected to be dangerous since these changes are
    supposed to be detected and the query state should become outdated
    anyway and require re-querying.
    
    Switching to a snapshot provides some consistency but at the cost of
    spawning a new bazel instance and re-loading all packages every time.
    
    Bug: 356244980
    Test: n/a
    Change-Id: Ib433ac2869700ff75d2c54c1bfefe1cf3ff9cc17
    
    AOSP: ca5831e5ebeee8eb51889e7726309ef5ef4b8cfd
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    b75b67e View commit details
    Browse the repository at this point in the history
  146. Default Java language level to 21

    Bug: 378841215
    Test: n/a
    Change-Id: I4bf573d2decafd5b3893fb5e653944cabc1d5d4d
    
    AOSP: f647f6fa18fe99d8e295703b37dfeae048363fba
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    ebcca94 View commit details
    Browse the repository at this point in the history
  147. Address pbfile not in workspace

    Bug: 375380927
    Test: n/a
    Change-Id: I3bc87aa016559f1552c45dc5c1ba0225fc13174d
    
    AOSP: aa84df91e1f973d0f11c371c76ed0363b2bc1e8f
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    6eb01a2 View commit details
    Browse the repository at this point in the history
  148. Do not instantiate Labels

    until required. In the worst case if the regex is wrong is parses out
    something that our Label implementation rejects it will appear in the
    error list.
    
    This change is to make it easier to understand why and what kind of
    labels is instantiated during build operations.
    
    Bug: n/a
    Test: n/a
    Change-Id: I53a6371be1ec2fc38dcd74acb7b2038e2612a064
    
    AOSP: 3e7c8ecfb0ccdc4fbe9e1bdfa862f2b267e87b0a
    Googler authored and LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    06f2cc5 View commit details
    Browse the repository at this point in the history
  149. WORKAROUND: removed usage of incompatible alarm constructor

    Since google targets 243 this constructor is not available in 242.
    LeFrosch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    f8c553f View commit details
    Browse the repository at this point in the history
  150. Configuration menu
    Copy the full SHA
    e9e8827 View commit details
    Browse the repository at this point in the history