Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update languages.toml - add nixd #10767

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

KiaraGrouwstra
Copy link
Contributor

@KiaraGrouwstra KiaraGrouwstra commented May 15, 2024

Closes #10734

@the-mikedavis
Copy link
Member

To fix the docs CI you can run cargo xtask docgen and commit the changes

@the-mikedavis the-mikedavis changed the title Update languages.toml - add nixd, closes #10734 Update languages.toml - add nixd May 16, 2024
@the-mikedavis the-mikedavis added the A-language-support Area: Support for programming/text languages label May 16, 2024
@KiaraGrouwstra
Copy link
Contributor Author

@the-mikedavis thanks, i pushed an update now :)

the-mikedavis
the-mikedavis previously approved these changes May 16, 2024
@cgahr
Copy link
Contributor

cgahr commented May 17, 2024

I'm not sure nixd is better then nil (at least for helix): nil seems to require less configuration, see oxalica/nil#111

Hence, I think, nil should have a higher priority compared to nixd. User who configure nixd can just disable nil or change the priority.

@KiaraGrouwstra
Copy link
Contributor Author

i've pushed an edit prioritizing nil.

@inclyc
Copy link

inclyc commented May 23, 2024

nil seems to require less configuration, see oxalica/nil#111

That's outdated somehow, there are some massive rewriting landed in nixd just a few months ago, features should work out of box.

@KiaraGrouwstra
Copy link
Contributor Author

should i put nixd on top again?

@inclyc
Copy link

inclyc commented May 24, 2024

should i put nixd on top again?

Disclaimer: I'm author of nixd.

I would like to recommend you put it on the top, but I think the should be decided by users.

@cgahr
Copy link
Contributor

cgahr commented May 27, 2024

should i put nixd on top again?

Disclaimer: I'm author of nixd.

I would like to recommend you put it on the top, but I think the should be decided by users.

Could you elaborate on the difference between nixd and nil?

@darinkishore
Copy link

I've found nixd catches more errors when working on my nix config, i tried nil for a week, switched to nixd and haven't looked back. anecdotal ofc, but that + more recent commits on nixd has caused me to use it as my default nix LSP.

@keinsell
Copy link

It would not be better to add --inlay-hints argument as default? Default configuraiton of typescript-language-server inclues inlay hints for example.

@KiaraGrouwstra
Copy link
Contributor Author

@keinsell aren't those enabled by default?

@VuiMuich
Copy link
Contributor

VuiMuich commented Aug 2, 2024

Sorry to come with this last minute, but wouldn't it make sense to also add formatter = { command = "nixfmt" }, while at it?

@the-mikedavis
Copy link
Member

See #11001

@keinsell
Copy link

keinsell commented Aug 3, 2024

@keinsell aren't those enabled by default?

Just checked in editor, yeah they seem to be provided by default - my bad.

@archseer archseer merged commit 3b306fa into helix-editor:master Aug 9, 2024
6 checks passed
mxxntype pushed a commit to mxxntype/helix that referenced this pull request Aug 14, 2024
GNUSheep pushed a commit to GNUSheep/helix that referenced this pull request Aug 19, 2024
kyruzic pushed a commit to kyruzic/helix that referenced this pull request Sep 27, 2024
plul pushed a commit to plul/helix that referenced this pull request Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-language-support Area: Support for programming/text languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lsp: support nixd
8 participants