feat: Add support for nginx configuration files #11823
Open
+63
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the-mikedavis
added
the
A-language-support
codingjerk
force-pushed
the
feat/nginx-lang
branch
2 times, most recently
from
0b49850
to
1b30dd6
Compare
codingjerk
force-pushed
the
feat/nginx-lang
branch
from
1b30dd6
to
a01338a
Compare
| name = "nginx" | ||
| scope = "source.nginx" | ||
| injection-regex = "nginx" | ||
| file-types = ["conf"] |
There was a problem hiding this comment.
This will conflict with hocon. We might need a glob pattern that would match the common places to put nginx files instead
Comment on lines
+3819
to
+3822
| roots = [] | ||
| comment-token = "#" | ||
| indent = { tab-width = 4, unit = " " } | ||
| auto-format = false |
There was a problem hiding this comment.
Suggested change
| roots = [] | |
| comment-token = "#" | |
| indent = { tab-width = 4, unit = " " } | |
| auto-format = false | |
| comment-token = "#" | |
| indent = { tab-width = 4, unit = " " } |
these keys are set to their defaults so they can be removed
There was a problem hiding this comment.
The capture names here need to be adjusted to the ones we use: https://docs.helix-editor.com/master/themes.html#syntax-highlighting
For example @number should become @constant.numeric
| (number) @number | ||
| (metric) @number | ||
|
|
||
| (regex) @regex |
There was a problem hiding this comment.
Let's highlight this as a string and add an injection for it in injections.scm to use the regex language:
((regex) @injection.content
(#set! injection.language "regex"))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.