Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AlwaysIncludeForViewSource #818

Merged
merged 7 commits into from
Sep 17, 2024
Merged

AlwaysIncludeForViewSource #818

merged 7 commits into from
Sep 17, 2024

Conversation

FoseFx
Copy link
Member

@FoseFx FoseFx commented Sep 11, 2024

Which issues does this pull request close?

closes #773

@FoseFx FoseFx force-pushed the issue/773-AlwaysIncludeForViewSource branch from e3905b9 to abad5a2 Compare September 12, 2024 06:17
@FoseFx FoseFx marked this pull request as ready for review September 12, 2024 07:36
@FoseFx FoseFx requested a review from a team as a code owner September 12, 2024 07:36
@FoseFx FoseFx requested review from PaulKalho, Paul-B98 and MaxSchaefer and removed request for a team September 12, 2024 07:36
@FoseFx FoseFx self-assigned this Sep 12, 2024
@FoseFx
Copy link
Member Author

FoseFx commented Sep 13, 2024

Blocked by #812 (fixes testcontainers)

@FoseFx FoseFx added the is-blocked This gets blocked. Check out "Blocked by #xyz" comments. label Sep 13, 2024
@FoseFx FoseFx removed the is-blocked This gets blocked. Check out "Blocked by #xyz" comments. label Sep 17, 2024
@FoseFx
Copy link
Member Author

FoseFx commented Sep 17, 2024

unblocked by cherry-pick

@FoseFx
Copy link
Member Author

FoseFx commented Sep 17, 2024

rr @PaulKalho @MaxSchaefer

MaxSchaefer
MaxSchaefer approved these changes Sep 17, 2024
View reviewed changes
Copy link
Member

@MaxSchaefer MaxSchaefer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Executing the steps of the tests manual on my local env results in migration issues. Even in a newly pulled repository. Probably an issue on my side. The tests are working perfectly.

@FoseFx FoseFx merged commit 6a406b8 into main Sep 17, 2024
42 checks passed
@FoseFx FoseFx deleted the issue/773-AlwaysIncludeForViewSource branch September 17, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxSchaefer MaxSchaefer MaxSchaefer approved these changes

@PaulKalho PaulKalho Awaiting requested review from PaulKalho PaulKalho is a code owner automatically assigned from helpwave/backend

@Paul-B98 Paul-B98 Awaiting requested review from Paul-B98 Paul-B98 is a code owner automatically assigned from helpwave/backend

Assignees

@FoseFx FoseFx

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set AlwaysIncludeForViewSource in GetProperty
2 participants
@FoseFx @MaxSchaefer