Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move cache out of the worktree #165

Closed
wants to merge 4 commits into from
Closed

Conversation

krlmlr
Copy link
Contributor

@krlmlr krlmlr commented Oct 8, 2023

For #96.

@krlmlr
Copy link
Contributor Author

krlmlr commented Oct 8, 2023

This action in action: https://github.com/tidyverse/blob/actions/runs/6445932389/job/17500507262#step:6:3405 .

Any idea why sccache fails?

@hendrikmuhs
Copy link
Owner

Did you look at the test? Maybe you have to adapt he location at this line:

https://github.com/hendrikmuhs/ccache-action/blob/main/.github/workflows/tests.yml#L59

@krlmlr
Copy link
Contributor Author

krlmlr commented Oct 15, 2023

Looks slightly better now, two tests are still failing. Do you agree that moving the cache out of tree is a good idea?

@hendrikmuhs
Copy link
Owner

Looks slightly better now, two tests are still failing. Do you agree that moving the cache out of tree is a good idea?

yes, I think this is a good idea

@krlmlr
Copy link
Contributor Author

krlmlr commented Aug 1, 2024

Let's see how far we get with the current implementation after #217. I still think the cache shouldn't live inside the worktree, let's discuss when this becomes an issue.

@krlmlr krlmlr closed this Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants