This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
Sync up console deprecation with rake deprecation #718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/heroku/command/run.rb
Outdated
| puts " * https://devcenter.heroku.com/articles/one-off-dynos" | ||
| puts " * https://devcenter.heroku.com/articles/rails3#console" | ||
| puts " * https://devcenter.heroku.com/articles/console-bamboo" | ||
| deprecate("`heroku #{current_command}` has been deprecated. Please use `heroku run rake` instead.") |
There was a problem hiding this comment.
Should say "Please use heroku run console" I think.
There was a problem hiding this comment.
Yeah, thanks, got that.
|
@mfine 👍 |
|
👏 |
|
|
|
👎 Don't listen to the haters, folks. |
|
@zeke yo, there was a lot of contention over this issue. See the the thread on "heroku fucking console". |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normalize the approach to console with rake. Run it, but spit out a deprecation message.