Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin version of the example alpine builder used in CI #668

Closed
wants to merge 1 commit into from

Conversation

edmorley
Copy link
Member

@edmorley edmorley commented Sep 7, 2023

In CI a pack build is performed using one of libcnb's example CNBs and the upstream cnb/sample-builder:alpine builder, in order to test that our static MUSL compile works with non-libc base images.

However, in #594 the version of that builder had to be pinned to an older release, to work around a temporary incompatibility between the latest version of the builder and the latest stable Pack CLI.

Now that Pack CLI 0.30 has been released, the latest alpine builder will work again.

GUS-W-14086879.

@edmorley edmorley self-assigned this Sep 7, 2023
@edmorley
Copy link
Member Author

edmorley commented Sep 7, 2023

Depends on buildpacks/samples#170

@edmorley edmorley force-pushed the edmorley/ci-alpine-latest branch 2 times, most recently from 2e0c776 to 14d5115 Compare September 25, 2023 12:52
In CI a `pack build` is performed using one of libcnb's example CNBs
and the upstream `cnb/sample-builder:alpine` builder, in order to test
that our static MUSL compile works with non-libc base images.

However, in #594 the version of that builder had to be pinned to
an older release, to work around a temporary incompatibility
between the latest version of the builder and the latest stable
Pack CLI.

That issue has now been resolved:
buildpacks/samples#170

So we can switch back to the latest image version again.
@Malax
Copy link
Member

Malax commented Feb 12, 2024

@edmorley should we close this as it won't apply cleanly anymore after #775. Or do you want to keep this around as a loud reminder?

@edmorley
Copy link
Member Author

I'm happy to close this for now; we have the TODO in the workflow file, plus I'm still subscribed to the upstream issue in their examples repo.

@edmorley edmorley closed this Feb 12, 2024
@edmorley edmorley deleted the edmorley/ci-alpine-latest branch February 12, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants