Skip to content
This repository has been archived by the owner on Jan 28, 2024. It is now read-only.

Remove need for app.json to specify pr-predestroy script #35

Open
douglascayers opened this issue Jun 18, 2018 · 1 comment
Open

Remove need for app.json to specify pr-predestroy script #35

douglascayers opened this issue Jun 18, 2018 · 1 comment

Comments

@douglascayers
Copy link
Contributor

Just as Heroku CI will automatically look for bin/test-compile and bin/test scripts, if it's possible for Heroku during review app destroy step to look for something like bin/pr-predestroy script then that would allow the buildpack to provide a default and developers not to have this knowledge in their app.json unless they wanted to customize the behavior.

Currently, developers are adding the below snippet to their app.json, which relies on underlying knowledge of what artifacts this buildpack generates.

image

@wadewegner
Copy link
Contributor

I don't think this is possible, which is why I have it setup to use the app.json. I totally agree that it requires an absurd amount of knowledge and that it's easy to miss.

@ike-delorenzo and @devarispbrown, do you have an item on the roadmap to provide a better way we can hook this in, ideally through the buildpack itself so it doesn't require anything by the developer?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants