Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: remove deprecated backup window flag #710

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

phm07
Copy link
Contributor

@phm07 phm07 commented Mar 7, 2024

This flag has been deprecated (and not working) since 2018: #147

@phm07 phm07 self-assigned this Mar 7, 2024
Copy link

codecov bot commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.14%. Comparing base (f2fb321) to head (2bddf46).
Report is 63 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #710      +/-   ##
==========================================
- Coverage   60.14%   60.14%   -0.01%     
==========================================
  Files         191      191              
  Lines        6808     6802       -6     
==========================================
- Hits         4095     4091       -4     
+ Misses       2099     2098       -1     
+ Partials      614      613       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jooola jooola changed the title fix: remove deprecated backup window flag feat: remove deprecated backup window flag Mar 7, 2024
@apricote apricote changed the title feat: remove deprecated backup window flag feat!: remove deprecated backup window flag Mar 8, 2024
@apricote apricote added this to the v2 milestone Mar 12, 2024
@apricote
Copy link
Member

This is a potentially breaking change. Even though this flag shows a warning since 2018, we should try to avoid making breaking changes on purpose.

I have created a v2 milestone and added this PR to it, so we have a list of things to tackle if we decide to work on it.

Copy link
Contributor

This PR has been marked as stale because it has not had recent activity. The bot will close the PR if no further action occurs.

@github-actions github-actions bot added stale and removed stale labels Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants