Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: no-useless-concat & one-var (uninitialized) #3717

Merged
merged 3 commits into from
Nov 2, 2019

Conversation

curbengh
Copy link
Contributor

@curbengh curbengh commented Sep 13, 2019

What does it do?

no-useless-concat somehow is not enforced in recent commits.

I also remove rules override in .eslintrc.json for consistency across hexo projects.

Removing rules override is also in preparation for prettier to avoid conflicting rules (e.g. [1], [2]).

How to test

git clone -b no-useless-concat https://github.com/curbengh/hexo.git
cd hexo
npm install
npm test

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.

@coveralls
Copy link

coveralls commented Sep 13, 2019

Coverage Status

Coverage remained the same at 97.17% when pulling e690eca on curbengh:no-useless-concat into c1bbac3 on hexojs:master.

@yoshinorin
Copy link
Member

yoshinorin commented Sep 18, 2019

Before we merge this PR, we should discuss use the prettier or not.

As you know active maintainers discussed this matter hexojs/eslint-config-hexo#7
But, it seems maybe not yet decided it.

PS: I agree to use prettier

@curbengh
Copy link
Contributor Author

curbengh commented Sep 19, 2019

Even without prettier, for consistency, we shouldn't override eslint-config-hexo in the first place.

@curbengh curbengh requested a review from a team October 17, 2019 06:28
tomap
tomap previously approved these changes Oct 17, 2019
@curbengh
Copy link
Contributor Author

Rebased

@curbengh
Copy link
Contributor Author

Ready for review.

@curbengh
Copy link
Contributor Author

curbengh commented Nov 2, 2019

@hexojs/core
ready for review.

@curbengh curbengh merged commit 764f6d2 into hexojs:master Nov 2, 2019
@curbengh curbengh deleted the no-useless-concat branch November 2, 2019 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants