Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: drop lodash for i18n filter #3810

Merged
merged 1 commit into from
Oct 31, 2019
Merged

refactor: drop lodash for i18n filter #3810

merged 1 commit into from
Oct 31, 2019

Conversation

SukkaW
Copy link
Member

@SukkaW SukkaW commented Oct 27, 2019

What does it do?

This PR is a part of #3753.

How to test

git clone -b drop-for-lodash-for-filter-i18n https://github.com/sukkaw/hexo.git
cd hexo
npm install
npm test

Screenshots

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.

@SukkaW SukkaW requested a review from curbengh October 27, 2019 12:48
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.0008%) to 97.263% when pulling 394ee9d on SukkaW:drop-for-lodash-for-filter-i18n into c48f6a8 on hexojs:master.

@SukkaW SukkaW requested a review from segayuu October 29, 2019 00:23
yoshinorin
yoshinorin approved these changes Oct 31, 2019
View reviewed changes
Copy link
Member

@yoshinorin yoshinorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@SukkaW SukkaW merged commit 7126202 into hexojs:master Oct 31, 2019
thom4parisot pushed a commit to thom4parisot/hexo that referenced this pull request Jan 17, 2020
@SukkaW
refactor: drop lodash for i18n filter (hexojs#3810)
79c963c
@snyk-bot snyk-bot mentioned this pull request Mar 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoshinorin yoshinorin yoshinorin approved these changes

@curbengh curbengh Awaiting requested review from curbengh

@segayuu segayuu Awaiting requested review from segayuu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SukkaW @coveralls @yoshinorin