Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: comment out missing tests #3976

Merged
merged 3 commits into from
Dec 18, 2019
Merged

Conversation

curbengh
Copy link
Contributor

@curbengh curbengh commented Dec 16, 2019

What does it do?

Not very keen on 'x pending' message at the end of unit test.
I added "missing-unit-test" to the comment. We can mention it in the roadmap, and contributor can simply search for the keyword to locate missing tests.

Add a missing test for list_archives helper.
load_database test is being worked on #3975

Revert #3742

How to test

git clone -b test-missing https://github.com/curbengh/hexo.git
cd hexo
npm install
npm test

Screenshots

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.

@@ -77,7 +77,7 @@ describe('deploy', () => {
});
});

it('deployer not found');
// it('deployer not found');
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of using x pending to show missing test, I suggest to add a note, like

// it('deployer not found'); missing-unit-test

Then we can mention it in the roadmap, and contributor can simply search for "missing-unit-test" to locate missing tests.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.137% when pulling f5a7b1f on curbengh:test-missing into c82082c on hexojs:master.

@coveralls
Copy link

coveralls commented Dec 16, 2019

Coverage Status

Coverage remained the same at 97.137% when pulling caf41c4 on curbengh:test-missing into c82082c on hexojs:master.

// return fs.exists(dbPath);
// }).then(exist => {
// exist.should.be.false;
// }));
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@curbengh curbengh merged commit 85855de into hexojs:master Dec 18, 2019
@curbengh curbengh deleted the test-missing branch December 18, 2019 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants