refactor(hexo_index): remove unused parameter #4153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SukkaW
reviewed
Feb 25, 2020
lib/hexo/index.js
Outdated
| }, wait); | ||
| if (immediate && !timeout) func.apply(context, args); | ||
| if (!timeout) func.apply(context, args); |
There was a problem hiding this comment.
Since there's no immediate is given in actual practice, should we just remove this line as it is always false?
There was a problem hiding this comment.
my understanding is that, after wait time, timeout will become null, then the condition will become true and execute func.apply(). But func.apply() is already in L85 which will also be executed after wait, so looks like L84 is also useless.
curbengh
force-pushed
the
unused-parameter
branch
from
c917041
to
6d45e40
Compare
SukkaW
approved these changes
Mar 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
immediateparameter is never called. Found by lgtm.How to test
Screenshots
Pull request tasks