Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: migrate typescript #5417

Merged
merged 6 commits into from
Mar 3, 2024
Merged

refactor: migrate typescript #5417

merged 6 commits into from
Mar 3, 2024

Conversation

D-Sketon
Copy link
Member

@D-Sketon D-Sketon commented Feb 7, 2024

What does it do?

Screenshots

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.

Copy link

github-actions bot commented Feb 7, 2024

How to test

git clone -b re/_test https://github.com/D-Sketon/hexo.git
cd hexo
npm install
npm test

@coveralls
Copy link

coveralls commented Feb 7, 2024

Pull Request Test Coverage Report for Build 7998818473

Details

  • 75 of 75 (100.0%) changed or added relevant lines in 27 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.53%

Totals Coverage Status
Change from base Build 7992247079: 0.0%
Covered Lines: 9325
Relevant Lines: 9369

💛 - Coveralls

uiolee
uiolee previously approved these changes Feb 7, 2024
Copy link
Member

@uiolee uiolee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great to me

@@ -7,7 +7,8 @@
"declaration": true,
"esModuleInterop": true,
"types": [
"node"
"node",
"mocha"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like it will load @types/mocha everywhere including src, I don't know if this is correct and acceptable

@@ -3,4 +3,3 @@ reporter: spec
ui: bdd
full-trace: true
exit: true
parallel: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason why parallel was disabled?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tried keeping parallel, but then tests containing async on my computer throw exceptions, and I don't know why
image
image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

parallel makes it easier to make tests timeout in my experience

@uiolee uiolee merged commit 3c7729d into hexojs:master Mar 3, 2024
21 of 23 checks passed
@D-Sketon D-Sketon mentioned this pull request Mar 3, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants