-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added scraper for IrishCentral #1416
Conversation
Co-authored-by: Joey <[email protected]>
Co-authored-by: Joey <[email protected]>
Co-authored-by: Joey <[email protected]>
Co-authored-by: Joey <[email protected]>
Co-authored-by: Joey <[email protected]>
Co-authored-by: Joey <[email protected]>
Co-authored-by: Joey <[email protected]>
Co-authored-by: Joey <[email protected]>
Co-authored-by: Joey <[email protected]>
Co-authored-by: Joey <[email protected]>
Co-authored-by: Joey <[email protected]>
Co-authored-by: Joey <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! Made some comments throughout, some of these changes will require test updates. Also once you're done with these be sure to run our test suite locally and the formatter as well. Let me know if you have any questions!
black .\recipe_scrapers\irishcentral.py && python -m unittest
The exception FieldNotProvidedByWebsiteException
should only be used when the site never provides the field and should only be used for mandatory fields (not an issue here just mentioning). So there should only be one implementation for total_time in this instance.
Co-authored-by: Joey <[email protected]>
Co-authored-by: Joey <[email protected]>
Co-authored-by: Joey <[email protected]>
Co-authored-by: Joey <[email protected]>
Co-authored-by: Joey <[email protected]>
Co-authored-by: Joey <[email protected]>
Co-authored-by: Joey <[email protected]>
Co-authored-by: Joey <[email protected]>
Co-authored-by: Joey <[email protected]>
Co-authored-by: Joey <[email protected]>
Co-authored-by: Joey <[email protected]>
Co-authored-by: Joey <[email protected]>
Co-authored-by: Joey <[email protected]>
Co-authored-by: Joey <[email protected]>
Co-authored-by: Joey <[email protected]>
@jknndy, I ran the formatter on the .py file, revised with your suggestions, and corrected some of the inconsistent test cases. Please let me know your thoughts. |
@jknndy, I am having trouble passing the linter (seemingly due to isort inconsistencies within init.py). I have ran For added context, I was also having isort issues within irishcentral.py; however, after I ran isort on that file, it passed the linter checks right away. Thanks! |
Co-authored-by: Joey <[email protected]>
Thanks again for the contribution @bencondemi ! |
Resolves #1167
With ingredients in "ul" structure and no yields ~ https://www.irishcentral.com/culture/food-drink/shepherds-pie-recipe
With ingredients in "p" structure and with yields ~ https://www.irishcentral.com/culture/food-drink/apple-jameson-tart-recipe