-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for grouprecipes.com #873
Conversation
@jknndy could I get your help with review/commentary for this pull request? (something of a trade for previous code reviews - although I don't think I can keep up with your pace of development!) |
…es for conciseness
@jayaddison, all looks good to me, added one comment about a possible description adjustment. I'm going to tackle adding some ingredient grouping support to some of the preexisting scrapers in place of adding new ones for the moment which should make for some easier reviews! |
Thanks @jknndy - I think your comment about the |
The .stripped_strings at the end of this removes the additional information that pops up if you click "Read more" unfortunately when you remove it it appends "read more" & "see less" to the output string. There doesn't seem to be many recipes that this applies to but I think the additional info could be useful on the odd occasion it appears. For example on this recipe it omits "Biscuit dough finishes this dish off for a filling meal all in one scoop."
|
Gotcha, yep. That's intentional in this case - I usually prefer a shorter |
(or, equivalently, that if the mis-shapen cupcake is provided to someone, then othe participants are able to see that that happened, and figure out a bit for themselves about what went on there; benign/voluntary/well-humoured/etc. I guess some could argue that a little bit of mischief and pecking-order behaviour is normal in social gatherings.. I think if we have the opportunity to do better, either at a cupcake party, or in a technical standard, then doing so is worth considering) |
I think I'll pause now because this is getting a bit rambly and potentially off-topic - but thank you for the opportunity to discuss this. |
Argh, wrong thread :) |
Re-opening.. |
Resolves #872.