Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

添加审批流按权限组独自发送钉钉通知的功能 #2322

Closed
wants to merge 4 commits into from

Conversation

hjweddie
Copy link

工单审批的流程通知是通知到固定的一个目标。 实际上审批流可能会涉及不同的部门、小组。 如提交工单后,先由开发组leader审批, 然后再由系统运维组审批。 两个审批环节分属不同小组,单个审批环节的通知能支持通知到不同小组会更加友好

@hjweddie
Copy link
Author

变更内容同 #2002
原作者暂时没空处理,协商后我帮忙代为跟进,原pr可以close

@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (d4b5ea9) 75.50% compared to head (c0af884) 75.54%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2322      +/-   ##
==========================================
+ Coverage   75.50%   75.54%   +0.04%     
==========================================
  Files         107      107              
  Lines       15460    15495      +35     
==========================================
+ Hits        11673    11706      +33     
- Misses       3787     3789       +2     
Files Coverage Δ
sql/admin.py 93.05% <100.00%> (+0.19%) ⬆️
sql/models.py 96.64% <100.00%> (+0.05%) ⬆️
sql/notify.py 88.53% <75.00%> (-0.43%) ⬇️
sql/utils/workflow_audit.py 96.83% <94.44%> (-0.17%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LeoQuote
Copy link
Collaborator

因为通知这块需求众多, 我这边在考虑再加一个事件推送, 把所有的工单事件(提交, 审批, 执行等)以 webhook 的形式传到外部 url, 由外部服务做实际的通知, 所以暂缓一下你的 pr, 希望理解.

@hjweddie
Copy link
Author

有个疑问,你想表达的架构,是archery项目内新增一个单独的服务来处理通知事件, 通知api不对收敛在项目内。还是说webhook的处理过程完全开放给用户处理呢?

@LeoQuote
Copy link
Collaborator

是你说的前一个方案,单独处理所有事件,不管需要还是不需要通知,发不发通知是外部服务的事情。

@LeoQuote
Copy link
Collaborator

LeoQuote commented Oct 13, 2023

#2333 我这边暂时提了一个草稿, 希望是合并之后你写起来更加容易. 等大概几周就能完成, 有什么建议可以在那个 issue 里提

@hjweddie
Copy link
Author

了解

@LeoQuote
Copy link
Collaborator

https://github.com/hhyo/Archery/wiki/notifier 关于刚合并的pr 我这边也更新了 wiki, 你可以参考一下看看.

@LeoQuote
Copy link
Collaborator

因为近期更改较多, 当前实现已经不适合merge, 如有需要请重新提交

@LeoQuote LeoQuote closed this Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants