Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove source branches in batch jobs if necessary #37

Merged
merged 1 commit into from
Apr 12, 2023

Conversation

xtermi2
Copy link

@xtermi2 xtermi2 commented Jan 13, 2023

fixes smarkets#354
original PR: smarkets#355

In batch jobs source branch deletion can be bypassed, despite the setting being enabled in the original merge request. This change will check if the source branch should be deleted and make the appropriate API call to delete if so

In batch jobs source branch deletion can be bypassed, despite the
setting being enabled in the original merge request. This change will
check if the source branch should be deleted and make the appropriate
API call to delete if so
Copy link

@slovdahl slovdahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@slovdahl slovdahl merged commit 346c621 into hiboxsystems:master Apr 12, 2023
@slovdahl slovdahl mentioned this pull request Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Source branches are not deleted when using batch mode
3 participants