Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency jsdom to v24 #251

Merged
merged 1 commit into from
Jan 23, 2024
Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jan 21, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
jsdom ^23.0.0 -> ^24.0.0 age adoption passing confidence

Release Notes

jsdom/jsdom (jsdom)

v24.0.0

Compare Source

This release reverts our selector engine back to nwsapi. As discussed in #​3659, the performance regressions from @asamuzakjp/dom-selector turned out to be higher than anticipated. In the future, we can revisit @asamuzakjp/dom-selector after it reaches nwsapi's performance on the two real-world benchmarks provided by the community.

Since reverting to nwsapi causes several functionality regressions, e.g. removing :has() support, we've decided to make this a major version.

Additionally:

  • Small fixes to edge-case behavior of the following properties: input.maxLength, input.minLength, input.size, progress.max, tableCell.colSpan, tableCell.rowSpan, tableCol.span, textArea.cols, textArea.maxLength, textArea.minLength, textArea.rows.

v23.2.0

Compare Source

This release switches our CSS selector engine from nwsapi to @asamuzakjp/dom-selector. The new engine is more actively maintained, and supports many new selectors: see the package's documentation for the full list. It also works better with shadow trees.

There is a potential of a performance regression due to this change. In our stress test benchmark, which runs most of these 273 selectors against this 128 KiB document, the new engine completes the benchmark only 0.25x as fast. However, we're hopeful that in more moderate usage this will not be a significant issue. Any help speeding up @asamuzakjp/dom-selector is appreciated, and feel free to open an issue if this has had a significant impact on your project.

v23.1.0

Compare Source

  • Added an initial implementation of ElementInternals, including the shadowRoot getter and the string-valued ARIA properties. (zjffun)
  • Added the string-valued ARIA attribute-reflecting properties to Element.
  • Fixed history.pushState() and history.replaceState() to follow the latest specification, notably with regards to how they handle empty string inputs and what new URLs are possible.
  • Fixed the input.valueAsANumber setter to handle NaN correctly. (alexandertrefz)
  • Updated various dependencies, including cssstyle which contains several bug fixes.

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

Copy link

vercel bot commented Jan 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
pintorajs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 21, 2024 4:07pm

Copy link

codecov bot commented Jan 21, 2024

Codecov Report

Attention: 27 lines in your changes are missing coverage. Please review.

Comparison is base (87f80b1) 91.06% compared to head (abdbd30) 91.93%.
Report is 123 commits behind head on master.

Files Patch % Lines
packages/pintora-diagrams/src/class/db.ts 92.98% 8 Missing ⚠️
packages/pintora-diagrams/src/dot/artist.ts 92.20% 6 Missing ⚠️
packages/pintora-diagrams/src/class/artist.ts 98.20% 4 Missing ⚠️
packages/pintora-diagrams/src/activity/artist.ts 92.30% 3 Missing ⚠️
packages/pintora-diagrams/src/class/config.ts 90.47% 2 Missing ⚠️
packages/pintora-diagrams/src/util/graph.ts 33.33% 2 Missing ⚠️
packages/pintora-diagrams/src/sequence/artist.ts 95.45% 1 Missing ⚠️
...kages/pintora-diagrams/src/sequence/artist/loop.ts 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #251      +/-   ##
==========================================
+ Coverage   91.06%   91.93%   +0.87%     
==========================================
  Files          69       88      +19     
  Lines        3994     5074    +1080     
  Branches      762      897     +135     
==========================================
+ Hits         3637     4665    +1028     
- Misses        357      409      +52     
Flag Coverage Δ
unittests 91.93% <96.68%> (+0.87%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hikerpig hikerpig merged commit 7c7ac38 into master Jan 23, 2024
12 checks passed
@renovate renovate bot deleted the renovate/jsdom-24.x branch January 23, 2024 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant